IssueHunt
Bug Bounty (New!)
Browse
Sign in with GitHub
sindresorhus/refined-github

Extension sometimes fails to run when custom CSS is injected #4376

cheap-glitch posted onGitHub

<!-- Thanks for reporting a bug! ⛰ Make sure the bug is caused by Refined GitHub. Try disabling the extension first. Show us the bug and help us replicate it, include: 1. A REAL URL where the bug appears. If it happens on a private repo, find an equivalent public URL. 2. A screenshot/video/gif of the issue, if it’s visual. 3. Any related errors in the browser’s console, if any. -->

I've recently added some custom CSS to hide the "Explore repositories" sidebar on the dashboard. This makes the extension fail regularly with the following error (Firefox 88.0.1, RGH 21.5.19):

TypeError: document.head is null refined-github.js:1913:30

The line in question: https://github.com/sindresorhus/refined-github/blob/83f233677157d21fb6ae11958fa45aa7ee99d65a/source/features/index.tsx#L91

Since this only happens (afaik) when opening new tabs (regardless of the URL), I'm guessing the extension tries to inject the CSS before the <head> exists and thus execution stops. This was probably introduced by #4352.

Edit: can confirm the bug goes away when removing the custom CSS.

I also had issues load too fast. I think we should up the delay to 15-20ms

posted by yakov116 almost 4 years ago

Delays never work. We need to check the dom first, that’s it. No timers will fix it. I wonder if we should just use contentScript.register to inject it. It’d be perfect on Firefox but I don’t know about Chrome (polyfilled). Its worth a try

posted by fregante almost 4 years ago

Why dont we just add the css after the while?

posted by yakov116 almost 4 years ago

For the reason described by the issue your original PR solved https://github.com/sindresorhus/refined-github/issues/4312

posted by fregante almost 4 years ago

That was when loading took 220ms now it's about 20-40ms. To put thing into perspective, I dont see any jump now for any css only feature.

posted by yakov116 almost 4 years ago

Fund this Issue

$0.00
Funded

Pull requests

Company
AboutMission
Community
SpectrumEmbed
Support
FAQTerms of usePrivacy policyCode of conductCredits
Connect
FacebookTwitter

© 2019 BoostIO, Inc.