Window/Tab freeze in Firefox (conflict with other extensions) #4343

This is also happening to me with the regular version of Firefox after upgrading to 21.5.9.

Can you visit the options page and use the "Find feature" at the bottom to identify which feature causes this?

Also, we need a link to a page where this happens, like the issue template requests.

It happens even here: https://github.com/sindresorhus/refined-github/issues/4343 As for "Find feature", I can't do it since the github tab is frozen and doesn't refresh.

I am experiencing the same issue on Ubuntu and firefox is similarly offering to temporarily suspend the extension.

• Firefox 88.0
• Refined github 21.5.9

I ran 'find feature' (very cool idea to automate search by dichotomy for the failing feature btw) on two different pages and the verdict was 'warning-for-disallow-edits' both times.

Thank you! warning-for-disallow-edits isn't run on this page so that's likely not the case.

Are other extensions enabled?

Does it happens spontaneously on load/reload or do you have to click/do something?

Do you see anything on this page that might have triggered it? https://github.com/sindresorhus/refined-github/releases/tag/21.5.9

What happens when you click on "Debug script"? Can you take a screenshot of the code it shows?

If the tab freezes completely, my only guess is that it's this new loop: https://github.com/sindresorhus/refined-github/pull/4316/files#diff-cb1dafea7a9c68c5c2ebb2d56f749b3506c13f7d26feeaf56c86521b25c60358R109-R112

But it should still not freeze it since it releases the thread every 10ms.

cc @yakov116 can you replicate this issue in Firefox?

I have the same problem - version 21.5.9, FF - 88.0.1, Win10

However, I cannot reproduce it all the time. For example, it freezes even on the home page for gists, ie. https://gist.github.com/, after few restarts (I also used "clear cache" and "Find feature" from the add-in options), now I can open gists without a problem.

Might be related or not. Usually, GitHub doesn't load and stays blank. Now it's partially loaded.

I have the same problem - version 21.5.9, FF - 88.0.1, Win10

However, I cannot reproduce it all the time. For example, it freezes even on the home page for gists, ie. https://gist.github.com/, after few restarts (I also used "clear cache" and "Find feature" from the add-in options), now I can open gists without a problem.

More steps to reproduce on Win10:

1. Create a new clean FF profile.
2. Add extension.
3. After the installation it navigates to the extension's start page - https://github.com/sindresorhus/refined-github/issues/3543 - no issues (I'm not logged in GitHub)
4. Refresh the page a few times - on some of the subsequent reloads you will receive "Redefined Github is slowing down firefox...". It also starts consuming all available memory and CPU. If you wait, it will finally load after a while (up to a minute) consuming 8-9GB in the firefox process.
5. If you refresh again - it might work for a few next refreshes and then starts freezing again.

Might be related or not. Usually, GitHub doesn't load and stays blank. Now it's partially loaded.

It looks like you're running an extra "protection" extension. What is it?

More steps to reproduce on Win10:

Can you profile the script in the developer tools to see what part of the code is taking a long time?

It looks like you're running an extra "protection" extension. What is it?

https://adguard.com/en/adguard-assistant/overview.html#firefox and also Adguard Desktop app.

Surprisingly when I turned off Adguard Desktop, I couldn't reproduce the issue both on mac and windows. Adguard seems to be causing this but it never happened before.

Might be related or not. Usually, GitHub doesn't load and stays blank. Now it's partially loaded.

It looks like you're running an extra "protection" extension. What is it?

More steps to reproduce on Win10:

Can you profile the script in the developer tools to see what part of the code is taking a long time?

This is what I have. However, for some reason, I'm not able to reproduce this issue on a clean profile anymore. Will try later and if it's successful, will attach a profile.

This is on a clean profile (did exactly the same steps from my previous message). However it looks like that after opening dev tools, enabling\disabling cache, the issue somehow disappears. I'm still not sure which actions lead the bug to be disappeared.

@azdanov Just curious if you follow my steps with a clean profile, will you have the same problem (with disabled adguard)?

And the last thing - for me it feels like that's a memory problem (leaks on something like that), which occurs only under certain circumstances. Because when it starts freezing it immediately consumes 2-4 additional GB of memory in just a few seconds.

Well, in the end for me that's also an anti-virus program. I have a Kaspersky antivirus. I checked different settings and found this:

In English:

Inject script into web traffic to interact with web pages If the check box is selected, Kaspersky Internet Security injects a web page interaction script into web traffic. This script ensures the operation of such components as Safe Money, Private Browsing, Parental Control, Anti-Banner, URL Advisor, and Secure Data Input.

When this is checked, it adds some "safety" information about links like on the image below (but I guess it's only one of the features):

As soon as I uncheck this setting, everything just works. If I have it checked and redefined-github enabled, then sometimes it freezes a page. If I have it checked and redefined-github disabled then again it works. So somehow the latest release of redefined-github affects some antiviruses behaviour.

If the tab freezes completely, my only guess is that it's this new loop: #4316 (files)

But it should still not freeze it since it releases the thread every 10ms.

cc @yakov116 can you replicate this issue in Firefox?

I can't test until tonight. But maybe the anti virus scanning is hacking the loop?

Maybe we should do 20ms and see if it helps?

👉 Does installing an older version fix it for you?

https://addons.mozilla.org/en-US/firefox/addon/refined-github-/versions/

Does everyone here have some antivirus or AdGuard installed? Please leave a comment.

This is on a clean profile

Thank you for the profiles. Unfortunately they don't say what's causing the delay

having the same issue. Tho I can't always reproduce it 🤔

👉 Does installing an older version fix it for you?

All worked fine for me before 12.5.9.

Does everyone here have some antivirus or AdGuard installed? Please leave a comment.

nope.

All worked fine for me before 12.5.9.

Can you install an old version as suggested? What's happening now might just be a coincidence.

@azdanov @s-KaiNet can you report this issue to those extensions as well?

After playing around a bit on version 21.5.1, I'm not seeing any slow downs/error popups anymore

I also tried version 21.5.1 on Firefox and no issues related to slow-downs or error messages from Firefox. I'm also running a DNS adblocker called pihole: https://pi-hole.net/

@unixfox @Dev-CasperTheGhost can you try https://github.com/sindresorhus/refined-github/suites/2701228648/artifacts/59535951 and see if you have an issue?

@yakov116 Works for me.

can you try sindresorhus/refined-github/suites/2701228648/artifacts/59535951 and see if you have an issue?

Nope. This works fine :D

@fregante I am going to revert that commit and do a release.

Ok With that?

I have the same problem using Firefox 88.0 on Linux 5.4 Zorin OS 15.3 with the following extensions: https://gist.github.com/Vicente015/74db589a4760cdb196dadf18af5e4111

I will try version 21.5.1.

Can you try https://github.com/sindresorhus/refined-github/suites/2701228648/artifacts/59535951

Can you try sindresorhus/refined-github/suites/2701228648/artifacts/59535951

When I click on "install add-on from file" and select that one it gives error and says it could not be installed because it's not verified.

Am I skipping some step or doing something wrong?

@Vicente015 You have to temporarily disable xpinstall.signatures.required inside about:config page in Firefox.

@Vicente015 You have to temporarily disable xpinstall.signatures.required inside about:config page in Firefox.

Thanks! Works fine now

Great! I released https://github.com/sindresorhus/refined-github/releases/tag/21.5.10

It may take some time to show up

If you encounter the same issue while on version 21.5.10 please leave a comment specifying which version you’re using.

Closing since it seems to be resolved. 🥳

Anyone here can test https://github.com/sindresorhus/refined-github/suites/2743556032/artifacts/60647440. We want to make sure we dont hace a regression.

Thanks!

Tested on Dev Edition 89 - for me it works without the issue.

Yup, been using it for about an hour and all seems to be working well for me too