sindresorhus/refined-github

`fit-textareas` isn't enabled on discussions #4342

aminomancer posted onGitHub

<!-- Thanks for reporting a bug! ⛰ Make sure the bug is caused by Refined GitHub. Try disabling the extension first. Show us the bug and help us replicate it, include: 1. A REAL URL where the bug appears. If it happens on a private repo, find an equivalent public URL. 2. A screenshot/video/gif of the issue, if it’s visual. 3. Any related errors in the browser’s console, if any. -->

I think the fit-textareas module needs to add some inline CSS to the textareas to revert the max-width: 500px rule on comment boxes, from form-validation.scss line 286. That's all, thanks for the great extension.


fit-textareas has been disabled in previous version due to https://github.com/sindresorhus/refined-github/issues/4275

What you're seeing is GitHub’s native feature. Ensure you're on the last Refined GitHub version and that fit-textareas is not disabled in your settings

posted by fregante almost 4 years ago

Yeah I'm on 21.5.9. The issues comment box I'm typing in right now seems to expand indefinitely. But when typing responses in discussions or PRs it seems to only expand to 500px height. fit-textareas is still showing up in options.html. I have it enabled currently. So it's doing nothing and github is expanding comment boxes itself?

posted by aminomancer almost 4 years ago

Thought I'd mention something else while I'm here. This might be caused by some other incompatibility, but when opening github URLs in new tabs, about 30% of the time the page gets stuck loading indefinitely, and Firefox gives me a notification that Refined Github is slowing the browser down, and offering a button to "Stop" the extension. I just started noticing this today, never happened until just a couple hours ago, and I use github almost daily so I assume I would have noticed it earlier if it was present.

The "Stop" button callback doesn't disable the extension or anything, and doesn't actually help the page load, so maybe it just destroys the extension's content scripts for that particular tab. The tab doesn't crash either, just gets stuck loading. Next time I notice it I'll try to inspect it a bit and maybe offer some better insight. I didn't notice any similar complaints in here and I do use other github-related extensions and a stylesheet, so I assumed it must be on my end somehow.

edit: oh and that's with a personal token set up btw. I've just tested it with octotree, octolinker, and my stylesheet disabled, and still reproduced it a couple times.

posted by aminomancer almost 4 years ago

The freezing issue is https://github.com/sindresorhus/refined-github/issues/4343 and should be fixed in 21.5.10

Where does this fit textareas issue happen exactly? Please post a link to such a page like the issue template requests. Also ideally a gif showing the problem would be super helpful

posted by fregante almost 4 years ago

Sorry, at the time I posted this, I assumed it was impacting all comment boxes. Here is the exact page where I noticed it, in the comment box at the bottom as well as the smaller reply box above it. I didn't realize the module had been disabled so I just inspected the textbox and saw it had a max-height rule, and assumed that was the cause.

posted by aminomancer almost 4 years ago

Thanks! Indeed fit-textareas isn't run on Discussions.

I opened an issue in the relevant repo: https://github.com/fregante/github-url-detection/issues/78

posted by fregante almost 4 years ago

Fund this Issue

$0.00
Funded

Pull requests