`selection-in-new-tab` should not be enabled everywhere #4272

fregante posted onGitHub

selection-in-new-tab is enabled on every page and it attaches a keypress handler even when not necessary. At the very least, this feature should be limited to places with navigations using include, like isRepoConversationList, isRepoTree and isNotifications

Are there any other pages where this feature applies?

I would rather do a select where exists .navigation-focus a.js-navigation-open[href]

posted by yakov116 almost 4 years ago

I think that really applies to every global feature. We could query the DOM everywhere or we could use a more efficient include

posted by fregante almost 4 years ago

close-out-of-view-modals hide-navigation-hover-highlight improve-shortcut-help linkify-user-location navigate-pages-with-arrow-keys parse-backticks profile-hotkey reload-failed-proxied-images selection-in-new-tab set-default-repositories-type-to-sources user-local-time

⬆️ ⬆️ ⬆️ ⬆️ ⬆️ ⬆️ ⬆️ ⬆️

Those are the features that are global.

posted by yakov116 almost 4 years ago

hide-navigation-hover-highlight should share the same include list
navigate-pages-with-arrow-keys same as above I think
reload-failed-proxied-images likely only markup files and hasComments. But those might be enough pages that maybe it can stay global

The rest of them can really be on almost every page

posted by fregante almost 4 years ago

This issue has been open for too long. It looks like an easy change. Should we leave it longer for someone new to come along and pick it up? Or shall I pick it up?

posted by shinenelson over 3 years ago

Or shall I pick it up?

It's all yours! It's mostly a matter of exploring GitHub and looking for pages that have lists (commits, files, notifications):

Open page
Press j to see if there's any selectable item

Please try to be thorough in this search or else we'd end up disabling it on pages that use it

posted by fregante over 3 years ago

I was looking for small, quick wins :wink: This is probably not it. I think I have already amassed enough issues for myself to do over the weekend :sweat_smile: But if no one gets to it, I will pick it up.

posted by shinenelson over 3 years ago

Fund this Issue

$0.00

Funded

Only logged in users can fund an issue

Pull requests

Do you want to work on this issue?

`selection-in-new-tab` should not be enabled everywhere #4272

Company

Community

Support

Connect