sindresorhus/refined-github

Do you want to work on this issue?

You can request for a bounty in order to promote it!

fit-textarea causing significant slow down when adding PR review comments #4266

gmaclennan posted onGitHub

<!-- Thanks for reporting a bug! ⛰ Make sure the bug is caused by Refined GitHub. Try disabling the extension first. Show us the bug and help us replicate it, include: 1. A REAL URL where the bug appears. If it happens on a private repo, find an equivalent public URL. 2. A screenshot/video/gif of the issue, if it’s visual. 3. Any related errors in the browser’s console, if any. -->

Browser: Safari 14.0.3 Example URL: https://github.com/digidem/mapeo-mobile/pull/566/files#

When reviewing a PR and adding a code comment with multiple lines, refined github causes a slowdown that results in a typing appearing on the screen a second or so after keys are pressed.

I ran the profiler on the page and identified that each keypress is calling the fitTextArea() function and takes ~5ms.

Turning off the fit-textarea feature resolves the problem and typing is not delayed any more.


Will be fixed in the next release

posted by yakov116 almost 4 years ago

Confirmed and hopefully it will be fixed in the next release. I don’t know when that’ll happen in Safari because releases aren’t automated there yet #3686

posted by fregante almost 4 years ago

For the time being, yes, disabling the feature is highly advised. I had to do the same for the past few months.

posted by fregante almost 4 years ago

We had to re-enable it due to https://github.com/sindresorhus/refined-github/issues/4275 unfortunately

posted by fregante almost 4 years ago

Fund this Issue

$0.00
Funded
Only logged in users can fund an issue

Pull requests