On Firefox, refined-github is a CPU sink #4263

Please try running “Find feature” at the bottom of the options page to identify the offending feature

Wow, binary search through the features, I am thrilled! I repeated the search 4 times, these are the results:

The change or issue is caused by ci-link. The change or issue is caused by bypass-checks. The change or issue is caused by ci-link. The change or issue is caused by ci-link.

So I suppose I made a mistake the second time, and the winner is ci-link.

on github.com plain?! Or when going into a repo?

Also is more likely to be bypass-checks. Can you try to disable that feature in the options and see if you have the issue?

Well, I tried switching off for both features. It is when I switch off ci-link that I get a clear drop in Firefox CPU usage. Btw, my test page is the present issue page.

It there a URL you can provide that I can test it?

I had edited my comment to say that the page we are seeing is the test page.
However, I am not testing under lab conditions since I have quite a few Firefox tabs open. I need to switch to a clean session to confirm the experiment.

ci-link is broken but it should not be causing any issues. Very interesting.

It might be causing issues specifically because it’s broken, but it seems strange nonetheless, it just fetched a page and appends a dom element. On what URL does this happen? Does it happen on every repo on every page of the repo? We need a URL

I'm seeing something similar on my system (Arch Linux), although not quite as drastic. With a single idle tab opened to any repo page and ci-link disabled, Firefox's CPU usage oscillates around 10%. When ci-link is enabled it's around 20%, with spikes over 30% (even though no interaction is performed at all). And from what I can see, a single thread is responsible for almost 50% of that usage.

For now I disabled ci-link for everyone since it's broken anyway #4260. If you still see CPU issues related to RG please comment again.

I also experience this. I have disabled ci-link for now to see if that indeed fixes the issue.

However I would say that this ticket should stay open until the CPU issues are either fixed or ci-link is removed/deactivated by default :point_up:

One thing to note though: For me the ci-link stuff did work quite well (except for the CPU issue)

After today's update RGH is using very much CPU, again. But it only happens from time to time, and I'm not yet sure what the cause is.

I'm using Firefox 88.0 with Ubuntu 18.04.

I'm also using Firefox 88.0 but on Ubuntu 20.04

So disabling ci-link did not solve the issue for me.

Something seems to get caught in an endless loop when loading a new GitHub page (in a new tab), preventing the page from loading. During that time the CPU usage goes to 100%. The page can only be loaded by temporarily disabling the RG addon or by retrying to open that page in a new tab (several times).

Is there a way to figure out what script is causing the seemingly endless loop?

I haven't seen this behavior anymore lately... maybe it has been fixed with 21.5.10?

I also experience this

Refer to https://github.com/sindresorhus/refined-github/issues/4343

maybe it has been fixed with 21.5.10?

Yes.

For some background https://github.com/sindresorhus/refined-github/pull/4316#issuecomment-838423309

Refer to #4343

Thanks for the hint. The issue described there does indeed seem to be the same thing I am experiencing :+1: