IssueHunt
Bug Bounty (New!)
Browse
Sign in with GitHub
sindresorhus/refined-github

Do you want to work on this issue?

You can request for a bounty in order to promote it!

`submit-review-as-single-comment`: Cannot read property 'removeAttribute' of undefined #4242

xneek posted onGitHub

  • crashes when trying to add 160 lines of suggestions (indentation in enum)
  • clearing local storage brings back to life, but comment hangs in pending
  • image
  • When trying to «Send now»
  • window alert image
  • in console image

Hmm I just tried it now and I did not get an error.

What version of the extension are you using? And are you on enterprise?

posted by yakov116 almost 4 years ago

I got the same error forever on Safari, I assumed it was broken just there.

posted by fregante almost 4 years ago

Hmm I just tried it now and I did not get an error.

What version of the extension are you using? And are you on enterprise?

  • Refined GitHub 21.4.13 on Google chrome 89.0.4389.128
  • Enterprise
posted by xneek almost 4 years ago

https://github.com/sindresorhus/refined-github/blob/44f4ddc09618b2dadea8ff1a7aa19380708f2e1a/source/features/submit-review-as-single-comment.tsx#L55

Needs to be changed .js-suggested-changes-contents

posted by yakov116 almost 4 years ago

Fund this Issue

$0.00
Funded
Only logged in users can fund an issue

Pull requests

Company
AboutMission
Community
SpectrumEmbed
Support
FAQTerms of usePrivacy policyCode of conductCredits
Connect
FacebookTwitter

© 2019 BoostIO, Inc.