IssueHunt
Bug Bounty (New!)
Browse
Sign in with GitHub
sindresorhus/refined-github

Collapse successive deleted/hidden comments #4186

Krzmbrzl posted onGitHub

<!-- 1. Make sure your requested feature makes sense for Refined GitHub: https://github.com/sindresorhus/refined-github/issues/2960 2. Include a REAL URL where the feature should appear. e.g. Do you want a feature to appear on the main page of a repo? Paste a link to a repo -->

Consider the following PR of mine: https://github.com/mumble-voip/mumble/pull/3743 It contains an awful lot of comments that were outdated or otherwise not longer relevant. In order to bring down the amount of posts in the PR, I decided to delete some of them. However there were now dozens of entries of me having deleted these comments and thus it kinda failed its purpose.

I am proposing to collapse successive "xy deleted comment from yz" messages into something like "xy deleted x comments". Maybe it would also make sense to do the same for hidden comments (aka: collapse multiple successive hidden comments with "N comments hidden").

Maybe it could even make sense to collapse successive commits in such PRs :thinking:

posted by Krzmbrzl about 4 years ago

We discussed this before and decided that this would be the best way to handle noise in discussions without hiding events by default, which are sometimes useful anyway: https://github.com/sindresorhus/refined-github/pull/4029

posted by fregante about 4 years ago

Well I don't want to hide these things. I would like for them to be collapsed. Therefore if someone is interested in these, they can expand them again.

This seems like a more fine-tuned approach than #4029. If you have already discussed this though, then I guess #4029 will do :shrug:

posted by Krzmbrzl about 4 years ago

Fund this Issue

$0.00
Funded

Pull requests

Company
AboutMission
Community
SpectrumEmbed
Support
FAQTerms of usePrivacy policyCode of conductCredits
Connect
FacebookTwitter

© 2019 BoostIO, Inc.