sindresorhus/refined-github

View File Broken in Firefox #4178

brian-avery posted onGitHub

<!-- Thanks for reporting a bug! ⛰ Make sure the bug is caused by Refined GitHub. Try disabling the extension first. Show us the bug and help us replicate it, include: 1. A REAL URL where the bug appears. If it happens on a private repo, find an equivalent public URL. 2. A screenshot/video/gif of the issue, if it’s visual. 3. Any related errors in the browser’s console, if any. -->

It seems that the view file link is broken on GitHub in Firefox. For instance:

Instead of directing you to the file in the branch, it looks like it's skipping the branch in the URL (github.com/AlexeyPerevalov/kubernetes/blob//pkg/scheduler/testing/wrappers.go)

This results in a 404 image

If I populate the branch in the URL: github.com/AlexeyPerevalov/kubernetes/blob/AddLimitsToReq/pkg/scheduler/testing/wrappers.go then it works.

If I disable refined-github, the link starts working

Looking in the console, I see:

state is null global.js:344
[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIDOMWindowUtils.addSheet]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone :: line 74"  data: no] ExtensionCommon.jsm:74:12
TypeError: i.default.detectStore(...) is undefined h1-check.js:1:1301
GEThttps://github.com/AlexeyPerevalov/kubernetes/blob//pkg/scheduler/testing/wrappers.go
[HTTP/2 404 Not Found 226ms]

[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIDOMWindowUtils.addSheet]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone :: line 74"  data: no] ExtensionCommon.jsm:74:12
TypeError: i.default.detectStore(...) is undefined h1-check.js:1:1301
XHRHEADhttps://github.com/AlexeyPerevalov/kubernetes/tree//pkg/scheduler/testing
[HTTP/2 404 Not Found 178ms]

XHRHEADhttps://github.com/AlexeyPerevalov/kubernetes/tree//pkg/scheduler
[HTTP/2 404 Not Found 171ms]

XHRHEADhttps://github.com/AlexeyPerevalov/kubernetes/tree//pkg
[HTTP/2 404 Not Found 258ms]

XHRHEADhttps://github.com/AlexeyPerevalov/kubernetes/tree/
[HTTP/2 404 Not Found 52ms]

XHRHEADhttps://github.com/AlexeyPerevalov/kubernetes/commits//pkg/scheduler/testing/wrappers.go
[HTTP/2 404 Not Found 263ms]

GEThttps://www.google.com/_/VerifiedReviewsGcrProxyUi/gen204/?tmambps=-1&rtembps=-1&rttms=-1
[HTTP/2 404 Not Found 18ms]

[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIDOMWindowUtils.addSheet]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone :: line 74"  data: no]

Duplicate of #4143

posted by yakov116 about 4 years ago

Thanks for looking at this so quickly. Just to clarify, I don't see any network errors other than the 404 for the missing branch and refreshing the page doesn't fix the issue.

posted by brian-avery about 4 years ago

If the URL should be

https://github.com/kubernetes/kubernetes/blob/111a4c5f2f461bb1bd0e33ca0ba0afdbd57befdc/pkg/scheduler/testing/wrappers.go

but is

https://github.com/AlexeyPerevalov/kubernetes/blob//pkg/scheduler/testing/wrappers.go

then it's not exactly #4143

posted by fregante about 4 years ago

Is there a workaround short of disabling the plugin?

posted by tvalentyn about 4 years ago

To me it looks like this has been fixed already. Had the problem 10 hours ago, not anymore. 👌🏻

posted by davidstosik about 4 years ago

Still broken for me in Chrome with RefinedGithub Version 21.3.26

posted by tvalentyn about 4 years ago

Oh yeah, you are right! It seems to happen on some, but (maybe?) not all pull-requests for me... 🤔

Update: it looks like enable-file-links-in-compare-view is the cause, as disabling it fixes the issue. And the possible error: image

posted by davidstosik about 4 years ago

Fund this Issue

$0.00
Funded

Pull requests