View File Broken in Firefox #4178
brian-avery posted onGitHub
<!-- Thanks for reporting a bug! ⛰ Make sure the bug is caused by Refined GitHub. Try disabling the extension first. Show us the bug and help us replicate it, include: 1. A REAL URL where the bug appears. If it happens on a private repo, find an equivalent public URL. 2. A screenshot/video/gif of the issue, if it’s visual. 3. Any related errors in the browser’s console, if any. -->
It seems that the view file link is broken on GitHub in Firefox. For instance:
- Go here: https://github.com/kubernetes/kubernetes/pull/100658/files
- Click on the 3 dots on the first file to open the menu.
- Click view file.
Instead of directing you to the file in the branch, it looks like it's skipping the branch in the URL (github.com/AlexeyPerevalov/kubernetes/blob//pkg/scheduler/testing/wrappers.go)
This results in a 404
If I populate the branch in the URL: github.com/AlexeyPerevalov/kubernetes/blob/AddLimitsToReq/pkg/scheduler/testing/wrappers.go then it works.
If I disable refined-github, the link starts working
Looking in the console, I see:
state is null global.js:344
[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIDOMWindowUtils.addSheet]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone :: line 74" data: no] ExtensionCommon.jsm:74:12
TypeError: i.default.detectStore(...) is undefined h1-check.js:1:1301
GEThttps://github.com/AlexeyPerevalov/kubernetes/blob//pkg/scheduler/testing/wrappers.go
[HTTP/2 404 Not Found 226ms]
[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIDOMWindowUtils.addSheet]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone :: line 74" data: no] ExtensionCommon.jsm:74:12
TypeError: i.default.detectStore(...) is undefined h1-check.js:1:1301
XHRHEADhttps://github.com/AlexeyPerevalov/kubernetes/tree//pkg/scheduler/testing
[HTTP/2 404 Not Found 178ms]
XHRHEADhttps://github.com/AlexeyPerevalov/kubernetes/tree//pkg/scheduler
[HTTP/2 404 Not Found 171ms]
XHRHEADhttps://github.com/AlexeyPerevalov/kubernetes/tree//pkg
[HTTP/2 404 Not Found 258ms]
XHRHEADhttps://github.com/AlexeyPerevalov/kubernetes/tree/
[HTTP/2 404 Not Found 52ms]
XHRHEADhttps://github.com/AlexeyPerevalov/kubernetes/commits//pkg/scheduler/testing/wrappers.go
[HTTP/2 404 Not Found 263ms]
GEThttps://www.google.com/_/VerifiedReviewsGcrProxyUi/gen204/?tmambps=-1&rtembps=-1&rttms=-1
[HTTP/2 404 Not Found 18ms]
[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIDOMWindowUtils.addSheet]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone :: line 74" data: no]