sindresorhus/refined-github

Conversation filters issue #4161

dnknn posted onGitHub

update: The Conversation filters page was incorrectly redirected, see at https://github.com/sindresorhus/refined-github/issues/4161#issuecomment-808770093

image

Try disabling the extension first: no problem! This problem has existed for a long time

configuration image


Use a correct title for this issue to describe it.

Can you paste the link to the final page that shows no results?

posted by fregante about 4 years ago

Use a correct title for this issue to describe it.

sorry for my English.....sorry...

Can you paste the link to the final page that shows no results?

https://github.com/pulls?q=is%3Aissue+is%3Aopen+author%3AπŸ‘€πŸ†”+archived%3Afalse+sort%3Aupdated-desc+is%3Aprivate

Current behavior: πŸ‘† , Correct behavior: πŸ‘‡

https://github.com/issues?q=is%3Aissue+is%3Aopen+author%3AπŸ‘€πŸ†”+archived%3Afalse+sort%3Aupdated-desc+is%3Aprivate

I understand the cause of this problem, i try /pulls ⟢⟿ /issues , It works fine!

But I don’t know why it is redirected as /pulls

posted by dnknn about 4 years ago

Likely this is why:

https://github.com/sindresorhus/refined-github/blob/3aadf2f9141107d7ca92e8753f2a66cbc10ebd9d/source/features/sort-conversations-by-update-time.tsx#L27-L30

But it shouldn't happen in this case. I still haven't tried to replicate. @yakov116 can you see it?

posted by fregante about 4 years ago

Yup those lines are the issue.

posted by yakov116 about 4 years ago

Lol I get it now. It happens because the is%3Apr selector also matches is%3Aprivate. Maybe we can fix this specific issue by adding :not([href*="is%3Aprivate"]), or an additional if could be placed by using GitHubURL alternative simple alternatives welcome.

or maybe just:

 for (const link of select.all('a[href*="/issues"]:is([href*="is%3Apr+"], [href$="is%3Apr"]))')) { 

Related: https://github.com/sindresorhus/refined-github/issues/4142

posted by fregante about 4 years ago

Fund this Issue

$0.00
Funded

Pull requests