sindresorhus/refined-github

Allow `batch-mark-files-as-viewed`'s "toggle all with alt-click" on checkbox label #4155

FloEdelmann posted onGitHub

In #4016, @yakov116 added the "toggle all with alt-click" to batch-mark-files-as-viewed, but it works only if you click directly on the checkbox (.js-reviewed-checkbox).

It'd be nice if it would also work when clicking on the whole label (.js-reviewed-toggle). A click or alt-click does trigger this one checkbox to change, but not all others.

grafik


It should probably be js-toggle-user-reviewed-file-form like the other 2

posted by fregante about 4 years ago

.js-toggle-user-reviewed-file-form looks too big:

grafik

.js-reviewed-toggle is exactly the clickable area:

grafik

The existing shift-click logic should also be changed to that IMO.

posted by FloEdelmann about 4 years ago

Indeed, that logic used the form because we’re catching the submit event in one case.

posted by fregante about 4 years ago

Fund this Issue

$0.00
Funded

Pull requests