sindresorhus/refined-github

Do you want to work on this issue?

You can request for a bounty in order to promote it!

Show `ci-link` for PR next to it's title/number #4086

ofirnk posted onGitHub

Similarly to repo CI status: https://github.com/sindresorhus/refined-github/blob/main/source/features/ci-link.tsx image

I propose adding a CI status next to PR name/title/number. Reasons:

  1. On long PRs - you need to scroll A LOT to see CI status (for example )
  2. When you're in another tab - like changes - you need to switch tabs to know CI status. So you need to switch tab to conversations + scroll to bottom.
  3. When you're already scrolled in changes view - you need to lose context to know CI status. Like half way thru review, or direct link

I suggest to attach it to PR title - like that (expanded) image

posted by ofirnk about 4 years ago

And like that (scrolled) image

posted by ofirnk about 4 years ago

Yeah, I like how GitHub already does this on the mobile app:

Screenshot_20210313202643.png

posted by kidonng about 4 years ago

For anyone that wants to do this see the feedback on https://github.com/sindresorhus/refined-github/pull/4100

posted by yakov116 almost 4 years ago

I do not think this is possible anymore as GitHub stopped showing CI links on fork commit list see https://github.com/sindresorhus/refined-github/pull/4415/commits

posted by yakov116 almost 4 years ago

Fantastic…

but maybe we can figure out their URL anyway if it still works

posted by fregante almost 4 years ago

Maybe just an extra request:

  1. Get the latest commit if it's not available on the page (for example on Files tab)
  2. Fetch the commit page and extract CI icon from it
posted by kidonng almost 4 years ago

2. Fetch the commit page and extract CI icon from it

What commit page are you referring to? Both in the PR and it the repo itself the ci-link is not there.

posted by yakov116 almost 4 years ago

Something like this or this.

posted by kidonng almost 4 years ago

Ohh I see next to the title of the commit.

posted by yakov116 almost 4 years ago

Maybe just an extra request:

Not ideal, especially since we already can't cache it. I'd rather just have it on the Conversation tab for the time being, and then maybe add a fetch if we have the commit information on the page or if have the direct URL to the icon.

posted by fregante almost 4 years ago

I'd rather just have it on the Conversation tab for the time being, and then maybe add a fetch if we have the commit information on the page or if have the direct URL to the icon.

From what I can see, there are three situations (please correct if there's something wrong):

  • On Conversations tab, the latest commit along with the icon is already presented (not always though? Not sure). We don't need to make any request.
  • On Commits tab, we have the latest commit but not the icon, so we need one request to get the icon.
  • On Changes tab, we don't (?) have the latest commit info, so we need two requests, one for the commit list and one for the icon.
posted by kidonng almost 4 years ago

On changes we have the "view file" link which includes the latest commit hash. On multiple commits I think there's "view changes at/between commits"

Latest commit from commit(s) tab --411aab..

image

image

image

posted by ofirnk almost 4 years ago
posted by ofirnk almost 4 years ago

Fund this Issue

$0.00
Funded
Only logged in users can fund an issue

Pull requests