The issue has been closed

PR approval counts not visible anymore #4043

mobilutz posted onGitHub

In the v21.2.23 the PR approval count is not displayed correctly anymore: Screenshot 2021-03-01 at 12 29 51

This is how it looked until a couple of days ago (don't know exactly when it "broke") Screenshot 2021-03-01 at 16 25 42

This is the CSS that should do this: https://github.com/sindresorhus/refined-github/blob/main/source/features/pr-approvals-count.css

I am running this setup:

MS Edge Version 88.0.705.81 (Official build) (64-bit)
Refined GitHub 21.2.23

There is no error in the JS-console that correlates to this. Although I do see some other non-related errors, but I do not want to bring them up here. I am just adding the errors here, to show what they are!!! Screenshot 2021-03-01 at 12 32 57

PS: I disabled the features that are throwing the JS-console errors:

clean-conversation-filters
highlight-non-default-base-branch

Outcome is still the same - approval count not displayed.

PPS: Source of this feature: https://github.com/sindresorhus/refined-github/pull/816

What URL are you seeing the errors?

posted by yakov116 about 4 years ago

What URL are you seeing the errors?

This is the Pull Requests URL .../pulls. I currently only work on a private repo, so providing the full URL does not help.

PS: It is not on GHE, we are using normal GitHub. I just looked through the corresponding PR: #4021

posted by mobilutz about 4 years ago

But I dont see any errors on https://github.com/sindresorhus/refined-github/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc

posted by yakov116 about 4 years ago

This was fixed by #4021 and should be released soon.

posted by cheap-glitch about 4 years ago

Thanks @cheap-glitch - I am now on v21.3.1 and it works again.

I though that the release with these changed happend already before I created the ticket.

posted by mobilutz about 4 years ago

No worries, thanks for the detailed report Lutz!

PS: Do you still see those errors on the new version? We fixed a lot of bugs in this version.

posted by fregante about 4 years ago

Fund this Issue

$0.00

Funded

Pull requests

PR approval counts not visible anymore #4043

Company

Community

Support

Connect