sindresorhus/refined-github

`parse-backticks` doesn't work in Discussions #3975

darkred posted onGitHub

I've started this discussion https://github.com/tophf/mpiv/discussions/50 and the text in backticks is not rendered, not in the post title, in the listing, even though the parse-backticks feature is listed ok in Console (2021-02-14_174406))

There's no error in Console.

Using Refined GitHub 21.2.9 with Chrome 88/Firefox 85.

<details> <summary>Screenshots</summary>

(in a fresh Chrome profile)

2021-02-14_174256 2021-02-14_174309

</details>

If I may help, checking https://github.com/sindresorhus/refined-github/blob/main/source/features/parse-backticks.tsx I see there's no selector for Discussion pages/listings. I think these would be:

  • .js-issue-title for discussion pages
  • a[data-hovercard-type="discussion"] for discussion listings

Thank you


PR Welcome @darkred willing to send one?

posted by yakov116 about 4 years ago

Yes, of course. I'll try to send one in a few minutes.

posted by darkred about 4 years ago
posted by darkred about 4 years ago

I see that the .js-issue-title selector for Discussion page titles of my PR, had to be removed, in PR https://github.com/sindresorhus/refined-github/pull/4136#issuecomment-805101315

posted by darkred almost 4 years ago

Correct the selector was too general

posted by yakov116 almost 4 years ago

Should I make a new PR for adding .gh-header-title > span.js-issue-title instead? I believe this selector is ok.

posted by darkred almost 4 years ago

No that is still not good since it applies to every issue page.

Also I would rather wait for #4135 before doing this change.

posted by yakov116 almost 4 years ago

Ok I'll just share the unique selector I found: .js-discussions-title-container .gh-header-title > span.js-issue-title.

(so I'll wait for #4135 to be addressed, and then ask you again at that time)

posted by darkred almost 4 years ago

The issue is not resolved, please reopen @yakov116 @fregante (or should we create a new one?)

posted by kidonng over 3 years ago

Fund this Issue

$0.00
Funded

Pull requests