sindresorhus/refined-github

Do you want to work on this issue?

You can request for a bounty in order to promote it!

Some way to filter "destructive" options #3964

asmeurer posted onGitHub

This idea was initially discussed at https://github.com/sindresorhus/refined-github/issues/3357#issuecomment-776349543. Some features of Refined GitHub are more "destructive" than others, in the sense that they affect more than just the user interface, but also affect actions that would be seen by other people. An example of such a feature would be the feature that disables wikis on new repos. These change my mental model of how GitHub works in a way that affects other users, so I prefer to disable them.

"Destructive" isn't really the right word here, but I'm unsure what this would be called.

Just having some way to filter only these options would be helpful, as it's hard to go through the whole options list.


Can we also have a checkbox (checked by default) for pr-branch-auto-delete?

When I recommended Refined GitHub to two groups of my friends, they were both surprised to find that the merged branch was deleted by the extension. Some of them even disabled the extension worrying that it may have more "unexpected" behaviors.

I didn't expect this either. The intention of the feature has no issue from my perspective, but the implementation can certainly be improved, reasons:

  • People will likely to notice the feature before it actually does anything.
    • Yes, the deletion is easily reversible, but the deletion itself can cause side effects. Not a very practical example: deleting a branch may cause a Continuous Development service to unassign a preview domain which may be in use.
    • Deletion is a destructive operation inherently, and this issue is (kind of) about making them more noticeable.
  • Not everyone is seasoned enough to know the existence of protected branches, and they are paid features for private repos.
  • As mentioned in #3636, this feature may make sense most of the time, but it won't suit every workflow, in which case it is reasonable to disable it temporarily.

More about my first point (could have already been considered though): many issues are opened because people are unfamiliar with some certain features. We have changelogs and #4004 which inform existing users with new features, but new users will either need to deal with every unfamiliarities or read the lengthy readme. We could have a list of these "destructive" or "controversial" features in the "Welcome to Refined GitHub" issue or somewhere else.

posted by kidonng almost 4 years ago

Fund this Issue

$0.00
Funded
Only logged in users can fund an issue

Pull requests