Wait for attachments to be uploaded before allowing comment submission #3881

the "New issue" form has this feature already, so we might be able to reuse it somehow.

The "New Comment/Update Comment" form has this feature too/

It just doesn't work due to conflict with

                S("[data-required-trimmed]", function (t) {
                    const e = t.currentTarget;
                    "" === e.value.trim() ? e.setCustomValidity(e.getAttribute("data-required-trimmed")) : e.setCustomValidity("");
                }),
                n("change", "[data-required-trimmed]", function (t) {
                    const e = t.currentTarget;
                    "" === e.value.trim() ? e.setCustomValidity(e.getAttribute("data-required-trimmed")) : e.setCustomValidity(""), O(e.form);
                }),

Not in Safari?

It just doesn't work due to conflict with

Did you take those 2 screenshots after changing something? Does it work or not? 🤔

I see what's going on now.

1. Upload code calls e.setCustomValidity('uploading'), disabling submission
2. data-required-trimmed calls e.setCustomValidity(''), enabling submission immediately after

All of this overlapping logic is why I was hoping that this could be solved by GitHub themselves rather than adding more code like in #3886.

Silly idea: Since the cause of this behavior overlap is data-required-trimmed, what if we dropped the attribute during the upload? I wonder if it's possible to fit right between the steps 1 and 2 described above.

1. select.all('[data-required-trimmed]')
2. On upload:start, drop data-required-trimmed
3. On upload:complete/error, add data-required-trimmed