The issue has been closed
Version: 20.12.9
Perhaps the is a feature, but I was pretty sure the merge destination used to show up. Now it doesn't. Or maybe doesn't when it's the main branch of the parent repo?
Anyway, it confused a few of us this morning so thought it'd be good to open a bug.
https://github.com/Safecast/safecastapi/pull/743
With extension on:
With extension off:
Correct, it doesn't show when you're merging to the default branch.
posted by fregante over 4 years ago 
Is there a way to disable this? I searched the options list and didn't find anything, but there are a lot of options, so I may have missed it.
Found it, it's "clean up conversation headers". I wouldn't mind the other changes so much, but hiding the default branch is confusing and isn't actually duplicated information.
@fregante You seem to mention issues where this behavior poses a problem/confusion within the original issue. I think this feature is fine except for hiding the base branch name. The base branch name is important when operating in different repositories with different base branches/git workflows. Maybe we could split this into two features:
- clean up conversation headers
- hide base branch name from pr headers
Since the default would still mean hiding both, from the extension’s point of view it’s easier to just hide them both at once.
The base branch name is important when operating in different repositories with different base branches/git workflows
Question: How do you use this piece of information?
Personally I just found that fact that "no branch means default branch" confusing. It's clearer to always show it. Another thing is that the default branch isn't necessarily obvious if you aren't familiar with the repo, especially given that many repos are now changing their default branch name from master to main. Finally, it's a symmetry break to hide the information in some cases. My eyes look to a particular part of the screen to find the branch information, and when it's not there, it makes it harder to figure out what is going on (I have to stop and carefully reread what everything says).
My eyes look to a particular part of the screen to find the branch information, and when it's not there, it makes it harder to figure out what is going on (I have to stop and carefully reread what everything says).
Took me some time to get used to this too.
posted by fregante about 4 years ago 
IssueHunt