The issue has been closed

Improve Safari version #3766

fregante posted onGitHub

Maybe after #3686

Safari appears to have a great way to handle host permissions:

the user is shown a popup when clicking the extension on a host we have permission for:

<img width="316" src="https://user-images.githubusercontent.com/1402241/100323553-90216780-2f8b-11eb-8b3e-2d8c704638b1.png">
the user can select additional domains from the options page:

<img width="506" alt="a" src="https://user-images.githubusercontent.com/1402241/100323761-d7a7f380-2f8b-11eb-81e7-931bba9feb24.png">

This means that the Safari version can drop everything that was needed to support GitHub Enterprise:

the activeTab permission
the contextMenu permission
webext-domain-permission-toggle
webext-dynamic-content-scripts

These changes should happen at build time, hopefully something that will be set up by #3686. In reality, once the permissions are gone, the 2 packages will be silent.

And

the Refined GitHub app should include instructions about how to enable it. Edit: Or maybe I can just include this information in the "Welcome" issue

Maybe many of these Safari-specific changes could be avoided if we just fix the regular permission toggle: https://github.com/fregante/webext-domain-permission-toggle/issues/10

posted by fregante over 4 years ago

Note: It turns out that Safari shows a toolbar button regardless of browser_action in manifest.json, just like Chrome does.

posted by fregante about 4 years ago

I fixed various "bugs" across several modules so GHE is now supported on Safari. 🥳

The injection can take a few hundreds milliseconds so it's not ideal, but for the time being it's good enough and no custom builds are required.

posted by fregante about 4 years ago

Fund this Issue

$0.00

Funded

Pull requests

Improve Safari version #3766

Company

Community

Support

Connect