`global-conversation-list-filters` creates faulty links #3731

It will be fixed in the next release (tomorrow)

Thank you for help. close it, because my problem's been solved.

@yakov116 The bug has not been solved until now in my Chrome browser. Is this fixed?

the bug cannot be shown on console but commented list is not updated.

the error would be shown in situation.

1. Click Pull Requests tab.
2. Click Commented tab.
3. Click Review Requests tab
4. Click Commented tab.

in 4th situation, PRs list is not updated.

Not happening by me

Can you please paste the error here?

Could there be an issue with a dashed username?

Can you paste the URLs of the steps 2 and 4? We will know exactly what's happening

1. https://github.com/pulls/review-requested
2. https://github.com/pulls/review-requested?q=is%3Apr+is%3Aopen+archived%3Afalse+commenter%3AKSH-code

when 2, Review Requests tab is still active. @fregante @yakov116

There is no error in console.

I have just found the bug with Yours tab as well.

This piece of code is not working:

https://github.com/sindresorhus/refined-github/blob/ae020ab5d6c851045b39cd794e384e7aa4c91f1e/source/features/global-conversation-list-filters.tsx#L35-L38

Or rather, the SearchQuery is probably unable to correctly remove the commenter: query due to the dash in the username

@fregante Hey, I'm back here issue. I was wondering this issue can be fixed soon. If no and I have time to fix this, I will fix on my own. but I'm newbie about TS. so to fix it will spend lots of time. 😂

The problem doesn't seem to be what I thought. This SearchQuery test passes correctly:

test('.remove with dash', t => {
    // Native "Review requested" query after user visits the `Commented` tab
    const query = new SearchQuery({q: 'is:pr is:open archived:false commenter:KSH-code sort:updated-desc review-requested:KSH-code'});

    // Replicates line 37 shown above
    query.remove('commenter:KSH-code');

    t.is(query.get(), 'is:pr is:open archived:false sort:updated-desc review-requested:KSH-code');
});

@fregante Hey, It's been a while. The problem has been solved by update via Chrome developer mode. It occured when pathname ends with /pulls/review-requested but now, only pathname represents /pulls

Oooops, I have just found the bug. The reason why the bug occurs is because of sort option. I'll fix soon.

Thanks ! :)