sindresorhus/refined-github

Duplicating comments section #3729

smac89 posted onGitHub

This is the error I see in FF devtools:

`profile-hotkey`: can't access property "dataset", select_dom(...) is null

And in Vivaldi (a Chromium-based browser):

`profile-hotkey`: Cannot read property 'dataset' of null

I'm not sure if the above actually has anything to do with the error which I will now describe in full

URL

https://github.com/ytdl-org/youtube-dl/commit/1fb034d029c8b7feafe45f64e6a0808663ad315e

The main issue I noticed is that after being on the page for a while, it starts duplicating the comments.

Example on FF:

Peek 2020-11-16 16-07

As of creating this issue, it has duplicated the comments 6 times!.

On Vivaldi:

Peek 2020-11-16 15-56

Live example showing how it occurs on FF

Peek 2020-11-16 14-24

What I do is scroll to the bottom of the page, then I scroll to about 3/4 of the page and start scrolling up and down erratically. After a couple seconds of doing this, the comments are duplicated and I scroll all the way down. You will notice the duplicated comments do not show profile icons beside the reaction emojis for each comment.

Furthermore, this does not seem to occur where I am not logged into github. I've opened a FF container tab where I'm not logged into Github, and I do not notice this issue. The same is true with Vivaldi: When I'm not logged in, the page displays as usual, no duplication.


I get the duplicate issue even with RG turned off

posted by yakov116 over 4 years ago

I can't replicate either way, I assume it was GitHub themselves glitching up because the comment section was quite active (including the reactions)

posted by fregante over 4 years ago

Yep, it just happened to me without Refined GitHub (notice the lack of reaction-avatars)

<img width="889" alt="" src="https://user-images.githubusercontent.com/1402241/99324810-a23c3100-283a-11eb-8449-fef473a4966b.png">

Thank you for the detailed report though!

posted by fregante over 4 years ago

Oh wow that's quite interesting. I guess I will raise the issue with Github...if that's even possible lol

posted by smac89 over 4 years ago

Fund this Issue

$0.00
Funded

Pull requests