Ability to preview `user-local-time` in 12h format #3597

I think this breaks the two following requirements:

• It makes sense as a default for everyone: I don't know about Asia, but here in Europe where I live, most people use the 24h time format (with the exception of England ofc, and maybe others?)
• It doesn't require options: seems that it would be a setting of user-local-time

• It makes sense as a default for everyone: I don't know about Asia, but here in Europe where I live, most people use the 24h time format (with the exception of England ofc, and maybe others?)

I agree that it makes sense as a default format for everyone, but it would be great if it could be customized/changed to 12h format. Also this is a feature request and you can always close the issue if you don't want to implement it, it's totally on you.

• It doesn't require options: seems that it would be a setting of user-local-time

Yes, that's what I meant.

Times are displayed as 24h across the site by GitHub as well, and also are the standard for flight travel (i.e. many are familiar with it even in 12h countries), so it’ll just have to stay (because we don’t offer per-feature options)

If/when web pages will be able to read the system settings, maybe that can change.

If/when web pages will be able to read the system settings, maybe that can change.

Wait, can't we do something like

timeFormat = /[AP]M$/.test((new Date()).toLocaleString()) ? 12 : 24;

?

That follows the locale, not the system’s settings (which may vary), but it looks like GitHub uses the local format as well.

<img width="201" alt="" src="https://user-images.githubusercontent.com/1402241/94348871-55d83000-0005-11eb-94be-742a9d92776d.png">

Accepted.

I think the solution is to just pass undefined here:

const timeFormatter = new Intl.DateTimeFormat(undefined, {
    hour: 'numeric',
    minute: 'numeric'
});

Thank you very much!