sindresorhus/refined-github

`batch-mark-files-as-viewed` only works in one direction #3549

fregante posted onGitHub

  1. Visit https://github.com/sindresorhus/refined-github/pull/3540/files
  2. Click "Viewed" on the 1st file
  3. Shift-click "Viewed" on the 3rd file

This works, 3 files are selected.

  1. Remove all "Viewed" marks
  2. Click "Viewed" on the 3rd file
  3. Shift-click "Viewed" on the 1st file

This doesn't work. Only 1 or 2 files are selected, not 3 as expected.

Whoever wrote this feature was a real dummy. Let me see who did...

``` $ git blame source/features/batch-mark-files-as-viewed.tsx Fregante (4): Add batch-mark-files-as-viewed feature (#3007) Extract page-detect.ts into github-url-detection (#3062) Lint (#3072) Meta: Reorganize utility functions (#3110) .--
.ohNMMMMMNh/
/hNMMMMMMMMMMMd
.dMMMMMMMMMy
ommNmmMMMMs
`+yNMMMMMMMMM/ Always has been . .ohdNyyNMMNNmMM/ -oyhMMmNmddddhso:- `/mMMmNdNMMMMMMMMMmyyys/ ohdNMMMMMMMMMMMMM/ /M .+sys/` .` `+NMMMNmmNNNmNMMdNomMM /dMMMMMN` /oyddNMh. .dMMMMMdshdmdmNMh/dMMMM Wait, it's all me? `NMNMMm :/:/yomMMhosssssymNMMMMMMMMMMMMMMMN+NNMM `+mmMMMMo sdMNMMmMMMMMMmNMMMMMMMMMMMMMMMh-MMMM +Mdmmdy+/. `+:.//sddNMMMmMMMMMMMMMMMMMMMMdsNMMM /MMMMMhhyo+h` `NmMMMMMMmNMMMMMMMmmosMMM +MMMMMd+/mhMMN- mmMMMMMMMMMMMNNMMMMMhmMMM :mMNNMd-/ohNMMN/ :MMmNNMMMNMMMMNNNMMMhhMMM sMMMMMd-hMMMM:MMMMNNMMMMMMMMMMMMMyNMM dMMMMN: .-MMMm :MMMMMMMmMMMMMMMMMMN. hMM mMMMMh.MMMy -MMMMMMMMMMMMMMMMMMy sMM -MMMMd. .MMMoMMMMMMm+mMMMMMMMMM+ /MM NMMNd+/ NMN. mMMMMMMMMMMMMMMMNd: mM hMMNdoN. -+ yMMMMMMMMMMMMMMMMN- :d :NMNydMs .NMMNmMMMMMMMMMMyd. -


can I work on this ??

posted by esakki-selvaraj over 4 years ago

Sure 👌

posted by fregante over 4 years ago

Is there a way I can test it before I initiate a pull request? @fregante

posted by esakki-selvaraj over 4 years ago

Follow the instructions in the Contributing.md file and test the extension in your browser.

posted by fregante over 4 years ago

Fund this Issue

$0.00
Funded

Pull requests