Include the zipped extension in each release #3545

Perhaps this would be easier as a separate release.yml workflow with - on.push: [tags], but the automatic GITHUB_TOKEN doesn't trigger other workflows. If anyone knows knows a workaround (other than providing another token) please let us know.

we can also include the built extension for each release.

For what purpose?

e.g. users wanting to test previous versions in Chrome without having to build the extension. Firefox hosts them on AMO (at least temporarily), but Chrome doesn't

@notlmn should this be part of https://github.com/notlmn/release-with-changelog?

@notlmn should this be part of https://github.com/notlmn/release-with-changelog

Or we could output release URL from that action, and use that to upload assets to the release using https://github.com/actions/upload-release-asset.

This is what https://github.com/actions/create-release does.

So everything seems to exist already except the changelog creation. I see 2 solutions:

• use GitHub’s 2 actions + a third one to generate the changelog
• merge all functionality into one action

The first one would be preferred for stability (it’s 66% maintained by GitHub) but the workflow would be stupidly long apparently: https://github.com/actions/upload-release-asset#example-workflow---upload-a-release-asset

The second one doesn’t feel very UNIX-y… but it’d be very convenient. It could still import those 2 actions and still offer all of its inputs/outputs (but perhaps it wouldn’t make it any easier)

The other action don't export their functions actually for us to compose, which leaves having to implement all of it anyway.

---

If we were to merge all of it into a single action then from https://github.com/actions/upload-release-asset#example-workflow---upload-a-release-asset,

• env and GITHUB_TOKEN can be dropped, as we already have token input
• upload_url can be dropped, making it internal
• asset_name can be dropped, using the filename itself (unless we want it to be something like refined-github-v20.4.9.zip or something)
• asset_content_type, I'm not sure about this, mime sniff?

---

Going with the first option makes it easier for composing other actions. And also we will not be using @actions/create-release here as @notlmn/release-with-changelog already creates one.

Resurfacing this one.

I pushed a demo commit (https://github.com/sindresorhus/refined-github/commit/cd7991b1334112d211425e9f7784dcbdcd0cf4c8) of the changes needed here. It's only missing:

• that upload_url parameter, it should probably be outputted by https://github.com/fregante/release-with-changelog/issues/34
• some exact pieces of information, like correct paths and filenames

PR(s) welcome