`batch-open-conversations` on repo without access fires too early #3534

waitfordomready: false doesn’t make sense here because the last item is near the end of the page, so the DOM is ready a few milliseconds later anyway.

Generally, if we use select.all, we don’t use waitfordomready: false

@fregante I think there should be 2 inits. The if and the else do not have anything in common. WDYT?

Agreed

@fregante if we wait for dom ready there is a terrible jump

https://github.com/yakov116/refined-github/commit/6a4f3ccad3443b6236789ea1bfaabf239512089c WDYT?

I’m not accepting any more selector-observer refactoring until we figure out how to avoid https://github.com/sindresorhus/refined-github/issues/3527 + https://github.com/josh/selector-observer/issues/30

Also I’m not particularly fond of how this looks, due to the duplicate elementReady.

As an immediate solution, you can add a single line before the for loop: await domLoaded

The jump isn’t that big, we have other features that do the same, like shorten-links and reaction-avatars

Yeah I agree. That why I didn't open a pr before asking. https://github.com/yakov116/refined-github/commit/8aa9447d281a4ae2cab6ddc29d29de1eb13b2e7c what about that?

I’m not particularly fond of how this looks, due to the duplicate elementReady.

you can add a single line

I thought it should be in its own init?

Ahh I missed this line - sorry

As an immediate solution, you can add a single line before the for loop: await domLoaded