The issue has been closed

Support compare diff URLs in `prevent-pr-commit-link-loss` #3528

fregante posted onGitHub

Copy-paste this URL in a comment a click "Preview"

https://github.com/sindresorhus/got/compare/v11.5.2...v11.6.0#diff-6be2971b2bb8dbf48d15ff680dd898b0R191

GitHub changes the URL to the following, breaking it

https://github.com/sindresorhus/got/compare/v11.5.2...v11.6.0diff-6be2971b2bb8dbf48d15ff680dd898b0R191

can I work on this issue?

posted by esakki-selvaraj over 4 years ago

@esakki-selvaraj go for it!

posted by yakov116 over 4 years ago

@yakov116 Can i get some more links so that I can check my Reg Expression!

posted by esakki-selvaraj over 4 years ago

posted by yakov116 over 4 years ago

Keep in mind that there's a pretty advanced regex (which avoids selecting the url twice) already set up:

And tested:

You should start from that regex: copy the regex, copy the tests (changing only the URLs) and make sure they pass.

posted by fregante over 4 years ago

it's working

posted by esakki-selvaraj over 4 years ago

Fund this Issue

$0.00

Funded

Pull requests