Do you want to work on this issue?

You can request for a bounty in order to promote it!

`open-all-notifications` should also visible when i select some notifications #3503

muescha posted onGitHub

Summary

show the open-notifications-button when i select the checkbox on a notification

Where

when i go to https://github.com/notifications?query=reason%3Amention

What i see

when i not select acheckbox - the button open-notifications-button
when i select a checkbox - the button open-notifications-button

What i Expect

the button open-notifications-button should also visible when i select checkboxes

Screenshots

PoC

Modifications

a) Show a second Button `Open Selected`

a add a second button, like the current button it can visible/hidden with css

b) change to get the selected notifications

depending on the button clicked the selection of notification can handled different (adding a data-selection-type="all" /data-selection-type="selected" to distinct the buttons

c) edge cases

hide the button, when a user clicks on "select all" and then on "select all 20.212 notifications" (selected counter is > count of checkboxes on the page)

current behavior:

Environment

Chrome: Version 84.0.4147.135 (Offizieller Build) (64-Bit) Refined GitHub: 20.8.16

issue #3487 PR #3488 batch-open-conversations add checkboxes to repo without read access`

There are only 2 situations where this makes sense:

Clicking Select all
Clicking Select by state, if this feature ever comes: https://github.com/sindresorhus/refined-github/issues/3229

If you intend to select each notification and then open them all at once, you'd be wasting a click!

Instead of "check, check, check, open all" (4 clicks) Use "ctrl-click, ctrl-click, ctrl-click" (3 clicks) to directly open each link in a new tab.

posted by fregante over 4 years ago

select-notifications has been implemented by @cheap-glitch now ☺️

posted by fregante over 3 years ago

Should this be implemented as a special case in open-all-notifications, or as a separate button handled by select-notifications? (The second approach makes the most sense to me, but I still want to check)

posted by cheap-glitch over 3 years ago

@cheap-glitch The way https://github.com/sindresorhus/refined-github/pull/4526 was implemented, it would indeed make more sense as part of select-notifications as you can select issues across repositories, and the open-all-notifications buttons are shown on the individual repository lists. I would expect the button to be right next to the Select dropdown instead.

posted by janpio over 3 years ago

a separate button handled by select-notifications?

The two are unrelated, one can select notifications without that button, even by clicking "All"

While technically it would be a separate button from "Open unread notifications", it still matches that feature and name almost exactly, except it defaults to "open unread"

posted by fregante over 3 years ago

Fund this Issue

$0.00

Funded

Only logged in users can fund an issue

Pull requests

Do you want to work on this issue?

`open-all-notifications` should also visible when i select some notifications #3503

Summary

Where

What i see

What i Expect

Screenshots

PoC

Modifications

a) Show a second Button `Open Selected`

b) change to get the selected notifications

c) edge cases

Environment

Company

Community

Support

Connect

Do you want to work on this issue?

`open-all-notifications` should also visible when i select some notifications #3503

Summary

Where

What i see

What i Expect

Screenshots

PoC

Modifications

a) Show a second Button Open Selected

b) change to get the selected notifications

c) edge cases

Environment

Related issues

Company

Community

Support

Connect

a) Show a second Button `Open Selected`