sindresorhus/refined-github

Solution to: review threads are hard to follow #3462

fregante posted onGitHub

With review threads, often the last comment on the page is not actually the last comment.

How can this be solved?


I'm thinking that we could add a link at the bottom of the conversation pointing to the last review comment. Mockup:

<img width="772" alt="" src="https://user-images.githubusercontent.com/1402241/90143827-fa642280-dd75-11ea-95ef-28526ae68b6c.png">

This would be similar to highlight-highest-rated-comment, except it would appear at the very bottom of the page, which is where people expect the latest change.


I come up with another feature request relating to this solution: Change the update informationupdated <time> ago/ on <date> to updated <time> ago/ on <date> by *** in issue lists if sorted by update date, and make it clickable, linking to "Latest comment" bubble you have mentioned above. (Would it be a kind of duplicate feature of the open-issue-to-latest-comment🤔? I still hope this feature can be added, though.)

posted by Geeyun-JY3 over 4 years ago

Makes sense, it would still be part of open-issue-to-latest-comment

Actually this feature could be changed to point to the latest visible change on the page, instead of "the bottom-most comment" and would be a partial solution to this issue.

posted by fregante over 4 years ago

Makes sense, it would still be part of open-issue-to-latest-comment

Actually this feature could be changed to point to the latest visible change on the page, instead of "the bottom-most comment" and would be a partial solution to this issue.

That’s great!

posted by Geeyun-JY3 over 4 years ago

Actually this feature could be changed to point to the latest visible change on the page

I happen to be 👎 on this change. This would be a "breaking change" I really like the current behavior and I use it all the time to jump to the last comment.

posted by yakov116 over 4 years ago

Isn't the last comment possibly in a review that's not at the bottom though?

posted by fregante over 4 years ago

I happen to be 👎 on this change. This would be a "breaking change" I really like the current behavior and I use it all the time to jump to the last comment.

Or just pointing to "Latest comment" bubble which is at the bottom of the conversation would be more acceptable, just like what I have said? In this case, jumping to the “latest changes” just need one more click on the button.

posted by Geeyun-JY3 over 4 years ago

Isn't the last comment possibly in a review that's not at the bottom though?

thats if you are looking at a pull request. for issues many tines I am looking to see a solution and check the last 2 comments is what I am looking for.

The truth is that I still miss https://github.com/sindresorhus/refined-github/pull/1879

posted by yakov116 over 4 years ago

I usually end up on a PR review from notifications, which most of the times links directly to a specific comment (which is supposedly the "last edited comment"). In the linear flow, I don't this feature making any difference except for a fancy button that points to the "last edited comment".

IMO PRs are supposed to be non-linear, in terms of comments, but I think that there should be view of activities (updates) on PR in linear order somewhere.

posted by notlmn over 4 years ago

i would prefer something like a timeline style - like the other points in the timelines

just tried to change the exisiting timeline etries from (https://github.com/sindresorhus/refined-github/pull/3479):

<img width="797" alt="Bildschirmfoto 2020-08-21 um 22 57 07" src="https://user-images.githubusercontent.com/184316/90934564-cf2aa480-e401-11ea-87ae-e941f07648f8.png">

posted by muescha over 4 years ago

I usually end up on a PR review from notifications, which most of the times links directly to a specific comment (which is supposedly the "last edited comment"). In the linear flow, I don't this feature making any difference except for a fancy button that points to the "last edited comment".

IMO PRs are supposed to be non-linear, in terms of comments, but I think that there should be view of activities (updates) on PR in linear order somewhere.

i also prefer the (email) notifications, to not miss a commit or a comment :(

my suggested timeline view solves also this problem from @notlmn, when there are many new comments in different review threads, then they show up as timeline like in the (email) notifications, but on the timeline

posted by muescha over 4 years ago
posted by yakov116 about 4 years ago

Indeed #4029 helps see the content that matters 🎉

posted by fregante about 4 years ago

@fregante So, how can I find the latest visible change on the page by using the conversation-activity-filter? TBH I don't get that😂.

Also, should I create a new separate issue for https://github.com/sindresorhus/refined-github/issues/3462#issuecomment-674944698?

posted by Geeyun-JY3 about 4 years ago

Fund this Issue

$0.00
Funded

Pull requests