`fork-source-link-same-view`: The `forked from` link will be broken if the case doesn't match #3393

Can you give us a direct link?

Can you give us a direct link?

It seems fine.

UPDATE: Ah, you mean the broken link? I added it to the OP.

No i mean what page were you on the I can try to reproduce the issue?

No i mean what page were you on the I can try to reproduce the issue?

Hm then I think I cannot, you can go to a parent repo that you have fork repo.

You can, this is the link: https://github.com/JohnTitor/rust-forge

It works correctly in my case:

<img width="347" alt="" src="https://user-images.githubusercontent.com/1402241/88309765-adf16e00-cd06-11ea-8153-cfdaa4ffc197.png">

Did the repo change the name of the main branch recently?

I can't reproduce. Also, this doesn't seem to have relationship with forked-to.

Did the repo change the name of the main branch recently?

It is still using master

You can, this is the link

Nah, this issue occurs only when you go to the repo using the shortcut link.

I can't reproduce. Also, this doesn't seem to have relationship with forked-to.

Hmm, it's weird.

Nah, this issue occurs only when you go to the repo using the shortcut link.

We don't have special logic for that button, it's just a normal link. It should make no difference if you directly visit https://github.com/JohnTitor/rust-forge

We don't have special logic for that button

We kind of have logic, but only if you're in a file or folder. Following these steps doesn't trigger that logic however:

Steps to reproduce

1. Visit a repo that you have fork repo.
2. Click the shortcut and go to (your) fork repo.
3. See forked from owner/repo link.

Ahh, yep this isn't the shortcut issue but still extension issue, I guess.

Could someone confirm the issue happens if you set your personal token and visit my fork repo e.g. johntitor/rust-forge (note that the capitalization, it should be johntitor, not JohnTitor)?

note that the capitalization, it should be johntitor, not JohnTitor

Confirmed

Thanks! Sorry for confusing, now we could say it's extension issue?

it's extension issue?

We know that it's caused by Refined GitHub, but it's not due to forked-to (the fork button) but fork-source-link-same-view

@kidonng how did you get it to error? What link?

how did you get it to error? What link?

https://github.com/johntitor/rust-forge

how did you get it to error? What link?

https://github.com/johntitor/rust-forge

👆 this is why we ask for the exact link when opening an issue.

its isRepoRoot failing

https://github.com/sindresorhus/refined-github/blob/fa73096928e267ec165452557d25a8226cc32d09/source/features/fork-source-link-same-view.tsx#L32-L35

👆 this is why we ask for the exact link when opening an issue.

They did give us the right link in the image, but we ignored the case difference 😂

So the fork button will give you all lowercase link, and when you visit it, boom, getDefaultBranch gives wrong info

its not supposed to run on that page at all

https://github.com/fregante/github-url-detection/issues/24 https://github.com/fregante/github-url-detection/pull/25

@yakov116 do you think https://github.com/fregante/github-url-detection/pull/25 will fix it?

I think so (I did not have time to test the PR)