Cache not invalidates #3383

Please stop opening more issues about the cache.

I just verified that it works exactly as expected:

• I had bugs-tab with this cached data: { data: 20, maxAge: 1595771254270 }
• That maxAge is in 4 days and 13 minutes (bugs-tab is set to expire in 30 minutes + 4 days)

1. I waited those 13 minutes
2. I refreshed this page
3. The tab still reported 20 because of the staleWhileRevalidate behavior
4. I refreshed this page
5. The tab reported 21 and the cached object was { data: 21, maxAge: 1595773212201 }, which is 4 days and 28 minutes

thanks for your patience and pointing me to the direction that i can check it myself.

1) break point

i found the cached data while creating a breakpoint in sources tab on refined-github.js at point const cachedItem = storageData[internalKey]; which would be here:

https://github.com/fregante/webext-storage-cache/blob/master/index.ts#L135

is this the only way i see the cached data? i don't find it in the dev-tools at Application/Cache/Cache Storage and not in Local Storage

2) refresh page

i understand it right that i have to do 2 normal page refreshs (<kbd>⌘</kbd>+<kbd>r</kbd>) before i get fresh data?

1. Run await browser.storage.local.get() in the extension console context
2. Yes. The first load after the expiration date will show the cached data, but also trigger the API request which updates the cache. The second load will use this new cache.

@muescha did you set the token? Is it still valid? Any errors in the console?

You may be pleased to know that I found an invalidation bug (https://github.com/fregante/webext-storage-cache/issues/21), but it only fails when the token is missing: https://github.com/sindresorhus/refined-github/issues/3340#issuecomment-663107083

the token is set in plugin:

<img width="103" alt="Token in Plugin" src="https://user-images.githubusercontent.com/184316/88336605-95e51300-cd35-11ea-9288-fec23a732615.png">

and it seems to be used (in last week - no more detailed info is there):

<img width="768" alt="Token" src="https://user-images.githubusercontent.com/184316/88336196-e0b25b00-cd34-11ea-8a09-c9802af14935.png">

Setup with this permissions only:

<img width="614" alt="Permissions" src="https://user-images.githubusercontent.com/184316/88336236-ee67e080-cd34-11ea-9b87-75984e731c0a.png">

the console is filtered for refined and show this: (i cutoff last line which says: s/refined-github? =12345 example number - i don't know if its a sensitive number) <img width="359" alt="Console" src="https://user-images.githubusercontent.com/184316/88336262-f9227580-cd34-11ea-8935-7792cbef7a3d.png">

and this:

<img width="331" alt="Bildschirmfoto 2020-07-23 um 22 46 28" src="https://user-images.githubusercontent.com/184316/88337081-62ef4f00-cd36-11ea-92a1-106bb2682f87.png">