The issue has been closed

`releases-tab` sometimes doesn't flow into overflow hamburger menu #3347

fregante posted onGitHub

This is due to a race condition

Be on any (responsive) page
Resize the window

Sometimes it disappears, sometimes it doesn't:

This might be due to the tab being added after GitHub looks for the tabs, so the DOM element should probably be added before the API call, hidden, and then unhidden/removed as necessary.

This might be the code responsible for this:

p(".js-responsive-underlinenav", {
    constructor: HTMLElement,
    subscribe: e=>{
        const t = e.querySelectorAll(".js-responsive-underlinenav-item");
        return async function(e, t) {
            await ge,
            Os(e, t)
        }(e, t),
        ae(window, "resize", ()=>Os(e, t))
    }
})

p is probably selector-observer and as soon as it finds the menu, it selects the items in it. releases-tab might not be in there yet.

posted by fregante over 4 years ago

Fund this Issue

$0.00

Funded

Pull requests

`releases-tab` sometimes doesn't flow into overflow hamburger menu #3347

Company

Community

Support

Connect