The issue has been closed

Automatically expand URL when viewing definition/references #3337

kidonng posted onGitHub

GitHub has a feature for quickly jumping to definition/references when hovering the code:

Notice that the links always point to full URL, and when you click it without expanding current page's URL (by pressing <kbd>y</kbd> or whatever, I bet everyone forgets to do this at some time 😄), the page will do an unnecessary (and annoying) full load.

I think it would be convenient if you can just click the definition/references links without worrying about expanding the URL manually.

Can you post a link to that file?

Also I don't know why but it doesn't appear most of the times for me. Maybe they didn't enable it on Firefox?

posted by fregante over 4 years ago

Link: https://github.com/sindresorhus/refined-github/blob/master/source/github-helpers/api.ts#L50

posted by kidonng over 4 years ago

This can be implemented via delegate. If the user clicks that exact link, without any modifier keys, change location.hash directly instead of following the link. Probably just

function followLocalLink(event) {
  if (event.delegateTarget.pathname === location.pathname) {
    location.hash = event.delegateTarget.hash;
    event.preventDefault()
  }
}
delegate(document, selector, 'click', followLocalLink)

posted by fregante over 4 years ago

Fund this Issue

$0.00

Funded

Pull requests

Automatically expand URL when viewing definition/references #3337

Company

Community

Support

Connect