sindresorhus/refined-github

Menu/Header is centred (instead of left-aligned) #3332

stephenpope posted onGitHub

<!-- Thanks for reporting a bug! â›° 1. Make sure the bug is caused by Refined GitHub. Try disabling the extension first. 2. Include a full URL where the bug appears. 3. Include a screenshot/gif Issues without a URL/screenshot will be closed -->

This is a great tool but I noticed today that the header menu is now centred when I have refined-github enabled.

Refined-Github = Disabled

image

Refined-Github = Enabled

image

Now I do use a modification (Stylus) to make github use a wide layout but this happens identically using either of the top two stylus plugins : https://github.com/mdo/github-wide https://github.com/xthexder/wide-github

.. so this issue seems like something changed with GitHubs styles and so this has effected refined-github in some way.


I don't use those plugin but have similar a problem in a gist page. Version 20.7.10 by the way.

image

posted by jfcherng over 4 years ago

Does the issue happen even when you disable those 2 extensions?

posted by fregante over 4 years ago

Thanks for taking a look :)

Here are the different states ..

refined-github: OFF / wide-github: OFF

image

refined-github: ON / wide-github: OFF

image

refined-github: OFF / wide-github: ON

image

refined-github: ON / wide-github: ON

image

posted by stephenpope over 4 years ago

Gists support is easily fixable, but if you want this to work correctly with those extensions, try asking them to specifically override our style (once we’re done adjusting it). It’s easier for them to override our style than it is for us to detect them and exclude them.

posted by fregante over 4 years ago

Sure .. i totally get that. Could you just ping this thread when you guys are done and I can either submit a patch or ask them to lok at it :) Any hints about what has chnaged / what to tweak would also be very much appreciated :D

posted by stephenpope over 4 years ago

Those extensions can cancel/override the padding we add in align-repository-header.css. It would be a change specific to Refined GitHub

posted by fregante over 4 years ago

@stephenpope after #3335, I think it can be undone with:

body:not(.full-width):not(.enterprise) .repohead:not(.gisthead) > * {
    padding-left: 0 !important;
}

You can try it in the CSS field in the options before suggesting it to them

posted by fregante over 4 years ago

@fregante Im afraid not .. correct selector but doesnt seem to override (sorry ive not done CSS in a long time!) .. image

Thanks for the help though.

posted by stephenpope over 4 years ago

I think after https://github.com/sindresorhus/refined-github/commit/2fa584de28950e268e519c82d853877cdaa354d7 this is required:

body:not(.full-width):not(.enterprise) main > .hide-full-screen > * {
    padding-left: 0 !important;
}
posted by lamont-granquist over 4 years ago

Fund this Issue

$0.00
Funded

Pull requests