The issue has been closed

Review requires comment even with pending comment(s) #3309

dertieran posted onGitHub

Run into an issue with submitting a review with pending comments. This happens because the pending comment isn't visible in the current page. (e.g. when stepping through the commits one by one)

I think this was added in 52991fea170973356c3fd54edd14b8ff046c053a, happy to provide a PR to fix this, but I wasn't sure what edgecase that commit fixes.

@fregante Can you maybe explain or link what the issue was that you fixed in 52991fea170973356c3fd54edd14b8ff046c053a? Because I think the solution before handled my use case, but it seem to be broken for your use case in the screenshot. But I don't really understand the issue just from the screenshot. :sweat_smile:

posted by dertieran almost 5 years ago

Fund this Issue

$0.00

Funded

Pull requests

Review requires comment even with pending comment(s) #3309

Company

Community

Support

Connect