sindresorhus/refined-github

Malpositioned close button in fork popup #3283

kidonng posted onGitHub

This is a bug of GitHub itself. I don't know if they forget to update the fork popup's style, but now we have this annoying close button:

chrome_FWVDi4gPHg chrome_9cOl5yBsVb

If you compare it to other popups you will notice the difference:

image

Checkout fork popup's title style:

image

position: relative seems to be the culprit. Let's try position: static then:

image

Fine, but the position is still wrong. Now add some style to make it looks consistent with other popups:

font-size: 14px;
font-weight: 600;
min-height: unset;

image

It definitely looks better! Maybe we should include these styles in Refined GitHub. I will email GitHub about the wrong style too.


It’s worth sending this feedback to GitHub instead since they’re working on the redesign.

posted by fregante almost 5 years ago

This can be done in a few CSS lines, maybe even just margin-top: 5px

PR welcome, add stright to refined-github.css

posted by fregante over 4 years ago

Fund this Issue

$0.00
Funded

Pull requests