sindresorhus/refined-github

Enter a directory / file by clicking its row in the file manager #3281

szmarczak posted onGitHub

https://github.com/sindresorhus/refined-github

image

For now you need to click on the directory name, in this case .github. But imagine it's just a. It should be possible to enter the directory just by clicking on its row, so it would be more convenient for people who have their mouse DPI set to high value.


[role="rowheader"] .js-navigation-open {
  display: inline-block;
  width: 100%;
}

Note this affect commit lists too.

This style extends the clickable area to the left side of the commit message, which IMO is acceptable (but may feel strange and hard to discover?)

posted by kidonng almost 5 years ago

I don't think we need to make the full row clickable, just the left side (from icon to commit message) would be fine (at least for me). Though I have no idea how to tell people which area is clickable in an elegant way as well.

posted by kidonng almost 5 years ago

We can do that for the commit message later. Usually commit messages are long. For a start we can do it for file names I think.

posted by szmarczak almost 5 years ago

just the left side (from icon to commit message)

That sounds like what it already is, can you post a mockup of the clickable area you have in mind?

Also we can't include the icon because of edit-files-faster

posted by fregante almost 5 years ago

We can do that for the commit message later

It's about consistency; why would the whitespace next to the filename be clickable while the whitespace next to the commit title isn't? As a user, they're feel the same.

posted by fregante almost 5 years ago

Sorry I didn't make it clear, the icon isn't included.

image

You can check out the CSS above, which I'm currently using.

posted by kidonng almost 5 years ago
posted by fregante over 4 years ago

This is not worth the CSS mess that this requires. The truncate class makes this even more difficult

posted by fregante over 4 years ago

Fund this Issue

$0.00
Funded

Pull requests