The issue has been closed

"Edit comment" button injection is not reliable #3279

nashbridges posted onGitHub

This is in Brave 1.10.93 Chromium: 83.0.4103.106 (Official Build) (64-bit). All shields are turned off (gray icon).

Oftentimes when I edit the comment, the button is gone after submitting:

After a full page refresh it is back again:

I can't reproduce this bug in Chrome 83.0.4103.116. When I submit the edit there, the icon is hidden for a split second, but then is always back.

In both browsers I see the console error during initial load (example page):

❌ Refined GitHub → more-dropdown → TypeError: Cannot read property 'append' of null
    at appendBefore (refined-github.js:3157)
    at createDropdown (refined-github.js:3171)
    at more_dropdown_init (refined-github.js:3184)
    at async runFeature (refined-github.js:2837)
    at async setupPageLoad (refined-github.js:2845)

however, I doubt it's related, because it does not appear during the submitting.

Thanks for reporting! This actually happens in chrome too. There’s likely another issue open about this.

posted by fregante almost 5 years ago

Same solution as https://github.com/sindresorhus/refined-github/pull/3409

posted by fregante almost 5 years ago

Thanks! I confirm the button is there even after a couple of edits.

posted by nashbridges over 4 years ago

Fund this Issue

$0.00

Funded

Pull requests

"Edit comment" button injection is not reliable #3279

Company

Community

Support

Connect