The issue has been closed

"The HEAD of master isn't tagged" but no commit count on `latest-tag-button` #3228

flatcap posted onGitHub

The latest-tag feature doesn't show the number of commits, just +.

The latest tag for my project, NeoMutt, is 20200501. master is currently 115 commits ahead of this tag.

tag

My release commits are signed. My tags are annotated and signed.

Annotated tags are a link to a message object which links to a commit. Perhaps we're missing a lookup.

Note: The commit history for master is linear. Releases aren't in branches.

<sub>edit: add note about history</sub>

Many thanks for creating Refined-Github :heart:

Yes, this is by design:

the previous solution didn't work on some repos (GitHub wasn't showing some required information) https://github.com/sindresorhus/refined-github/issues/2927
GitHub doesn't offer a lightweight way to compare branches. The API endpoints we found could take a few seconds to respond with a sizable HTTP response if the comparison was large https://github.com/sindresorhus/refined-github/pull/2771#discussion_r378109419
the initial objective of the feature was to tell you whether HEAD was tagged https://github.com/sindresorhus/refined-github/issues/2601

We added the number to understand how stale it was, but after a certain number it doesn't matter anymore: It just means that it's very stale.

We still show the number, but we only look for the first 20 commits due API limitations. Anything more it's "undeterminable", also because on some repos the tags are not on the same branch at all, so it could be just 1 commit behind, but we can't know without a proper Compare API.

posted by fregante almost 5 years ago

OK. Thanks for explaining. (love the Impossible tag :-)

posted by flatcap almost 5 years ago

Fund this Issue

$0.00

Funded

Pull requests

"The HEAD of master isn't tagged" but no commit count on `latest-tag-button` #3228

Company

Community

Support

Connect