sindresorhus/refined-github

The issue has been closed

`linkify-code` runs multiple times on the same URL #3226

fregante posted onGitHub

This became visible when running the github-issue-link-status extension:

<img width="758" alt="" src="https://user-images.githubusercontent.com/1402241/84527576-71316080-acde-11ea-856e-db9f72915a36.png">

<img width="761" alt="" src="https://user-images.githubusercontent.com/1402241/84527918-03d1ff80-acdf-11ea-9453-956095f8ef40.png">

Test: https://github.com/sindresorhus/refined-github/pull/3225#discussion_r439535538

From my quick debugging, look like it gets run 2 times Here: https://github.com/sindresorhus/refined-github/blob/0fa514dbeeab6395ef095cff80beac41443a6574/source/features/linkify-code.tsx#L20-L23 and Here: https://github.com/sindresorhus/refined-github/blob/0fa514dbeeab6395ef095cff80beac41443a6574/source/features/linkify-code.tsx#L25-L28

posted by yakov116 over 4 years ago

linkifyIssues doesn't affect URLs though, just issue references like #3226

posted by fregante over 4 years ago

linkifyIssues doesn't affect URLs though, just issue references like #3226

Your right my bad.

From my quick debugging

I guess that was too quick 😃.

posted by yakov116 over 4 years ago

look like it gets run 2 times

Thanks for the tip, come up with a fix

posted by kidonng over 4 years ago

Having this issue again https://github.com/sindresorhus/refined-github/pull/3589/files

posted by yakov116 almost 4 years ago

Better rename the title to linkify-code since it is renamed.

posted by kidonng over 3 years ago

Fund this Issue

$0.00

Funded

Pull requests

Company

Community

Support

FAQ Terms of use Privacy policy Code of conduct Credits

Connect

Facebook Twitter

© 2019 BoostIO, Inc.