The issue has been closed

`prevent-pr-commit-link-loss` doesn't respect URL hash #3222

FloEdelmann posted onGitHub

E.g. for the following link:

https://github.com/sindresorhus/refined-github/pull/3205/commits/1da152b3f8c51dd72d8ae6ad9cc96e0c2d8716f5#diff-932095cc3c0dff00495b4c392d78f0afR60

… it should rather suggest the following:

- [https://github.com/sindresorhus/refined-github/pull/3205/commits/1da152b3f8c51dd72d8ae6ad9cc96e0c2d8716f5 ](https://github.com/sindresorhus/refined-github/pull/3205/commits/1da152b3f8c51dd72d8ae6ad9cc96e0c2d8716f5)#diff-932095cc3c0dff00495b4c392d78f0afR60
+ [https://github.com/sindresorhus/refined-github/pull/3205/commits/1da152b3f8c51dd72d8ae6ad9cc96e0c2d8716f5#diff-932095cc3c0dff00495b4c392d78f0afR60](https://github.com/sindresorhus/refined-github/pull/3205/commits/1da152b3f8c51dd72d8ae6ad9cc96e0c2d8716f5#diff-932095cc3c0dff00495b4c392d78f0afR60)

In short:

- [pr_url/commits/commit_ref ](pr_url/commits/commit_ref)#hash
+ [pr_url/commits/commit_ref#hash](pr_url/commits/commit_ref#hash)

Also, it adds an unnecessary space after the commit ref.

I'll do it unless you're already working on it

posted by fregante almost 5 years ago

I'm not, please go for it :)

posted by FloEdelmann almost 5 years ago

Fund this Issue

$0.00

Funded

Pull requests

`prevent-pr-commit-link-loss` doesn't respect URL hash #3222

Company

Community

Support

Connect