IssueHunt
Bug Bounty (New!)
Browse
Sign in with GitHub
sindresorhus/refined-github

Getting "PR is already touching this file" warning even though PR is closed #3125

LewisTehMinerz posted onGitHub

<!-- Thanks for reporting a bug! â›° 1. Make sure the bug is caused by Refined GitHub. Try disabling the extension first. 2. Include a full URL where the bug appears. 3. Include a screenshot/gif Issues without a URL/screenshot will be closed -->

On a file in the PreMiD/Schemas repository (specifically https://github.com/PreMiD/Schemas/blob/master/schemas/metadata/1.0.json) Refined GitHub thinks that an already merged PR is still open and always warns me that it's touching the file. However, said PR is merged: PreMiD/Schemas#1.

When PreMiD/Schemas#2 was created and closed normally, however, the warning disappeared saying that multiple PRs were touching the file.

image image

The PR was merged recently. What you’re seeing is just cache that hasn’t expired yet

posted by fregante almost 5 years ago

I just saw this today for a PR that closed in Feb ... how long does the cache last?

posted by swrobel almost 5 years ago

It should only last 1 + 9 days: https://github.com/sindresorhus/refined-github/blob/2235c23dedef9f5ef91cc07c53175e28e5f64b6d/source/features/list-prs-for-file.tsx#L91-L92 (meaning that if you open it after 24 hours of the closure, it will revalidate the cache, so if you refresh the page it should be gone)

Is is still there for you now? I never see it for very long

posted by fregante almost 5 years ago

I already opened the PR and it's since been merged so it's impossible to test again with this scenario. If I see it again, I'll try refreshing the page.

posted by swrobel almost 5 years ago

Fund this Issue

$0.00
Funded

Pull requests

Company
AboutMission
Community
SpectrumEmbed
Support
FAQTerms of usePrivacy policyCode of conductCredits
Connect
FacebookTwitter

© 2019 BoostIO, Inc.