The issue has been closed

"View file" is broken when using RefinedGithub #3123

FearlessTobi posted onGitHub

As a reproduction case, click View file in the dropdown here: https://github.com/yuzu-emu/yuzu/pull/3976/files

This causes me to end up on https://github.com/yuzu-emu/yuzu/blob/qdarkstyle_fix_prop/dist/qt_themes/qdarkstyle/style.qss whereas it should lead me to https://github.com/yuzu-emu/yuzu/blob/ea14af2164934faa0761a88c6236b3652d8cdaea/dist/qt_themes/qdarkstyle/style.qss.

This issue doesn't occur when the plugin is not installed.

@FearlessTobi update the extension. It looks like it published already!

posted by yakov116 almost 5 years ago

Not your fault, I think the issue has been there forever, but I just noticed it when reviewing your PR 😃

posted by fregante almost 5 years ago

I don't want to open a new issue for this and I'm not sure if this fixed already from glancing at the commit history, but "View file" seems to be broken again.

For example here https://github.com/yuzu-emu/yuzu/pull/3953/files#diff-41128cb4d8543fc3dc355acefa28cd61L137, it redirects me to https://github.com/GodKratos/yuzu/src/yuzu/main.cpp whereas it should lead to https://github.com/yuzu-emu/yuzu/blob/60b184377ee15e487e630a3cadc18f3c1b4312b3/src/yuzu/main.cpp.

posted by FearlessTobi almost 5 years ago

I know about it and I have a fix for it. The issue is only for PR's opened from the default branch. I am waiting for after https://github.com/sindresorhus/refined-github/pull/3152

posted by yakov116 almost 5 years ago

Fund this Issue

$0.00

Funded

Pull requests

"View file" is broken when using RefinedGithub #3123

Company

Community

Support

Connect