The issue has been closed

Restore `reactions-avatars` #3122

fregante posted onGitHub

Github no longer loads who reacted in the aria-label until you hover 😞

Originally posted by @yakov116 in https://github.com/sindresorhus/refined-github/issues/3120#issuecomment-632331245

reactions-avatars stopped working (https://github.com/sindresorhus/refined-github/issues/3120) because of this change.

The feature used to look like this:

Since the usernames are no longer available on the DOM until it's too late, the only fix is to load these usernames via the API.

The problem is that this call might be rather large on very active discussions, so this might no longer be worth it.

PR welcome to figure out what changes are required and what the impact would be on large conversations like https://github.com/facebook/react/issues/13991

Neither solution is great, I’d very much prefer triggering GitHub’s own queries on hover than calling the API, as I mentioned in my comment.

I thought this was broken, but it actually might be the browser. Not sure, but I do see that label getting updated.

Much better implementation.

First time looking at React/TypeScript. This was pretty cool. Thanks for insight.

posted by jef almost 5 years ago

Looks like github went back to the old way!!

posted by yakov116 almost 5 years ago

PR welcome to drop the first ~10 lines of showAvatarsOn

posted by fregante almost 5 years ago

Fund this Issue

$0.00

Funded

Pull requests

Restore `reactions-avatars` #3122

Company

Community

Support

Connect