sindresorhus/refined-github

Wrong avatars on reactions #3120

Almo7aya posted onGitHub

This bug happens in any PR or issue reactions when it shows the people who react to something, it always keeps showing the same accounts

image

Starting from user https://github.com/1 and increases the id as the count of the people reacted to the issue increased

image


Link?

posted by yakov116 almost 5 years ago

I'm facing it in everywhere @yakov116 image

posted by Almo7aya almost 5 years ago

image

posted by yakov116 almost 5 years ago

How? I disabled the extension and it worked fine

posted by Almo7aya almost 5 years ago

Maybe its another github extension interfering. Can you try to disable all other extensions?

posted by yakov116 almost 5 years ago

I'm facing it in everywhere image

You added both reactions so the same avatar appears on both. What do you expect if not this?

posted by fregante almost 5 years ago

Something weird is going on for sure though, this can't happen:

image

It shows that you clicked on the second reaction, but it also shows 1 avatar.

image

Here it shows your avatar… that should never happen. Could it be that your username is causing problems (since it has an uppercase letter)?

posted by fregante almost 5 years ago

How? I disabled the extension and it worked fine

Try disabling other extensions, not Refined GitHub. If you disable Refined GitHub the avatars won't show at all.

posted by fregante almost 5 years ago

I can confirm this happening. Couldn't figure out what extension is interfering (tried disabling each one in turn). Reinstall doesn't work.

Doesn't happen in chrome canary clean install, though, so some interference indeed must be happening.

posted by dwelle almost 5 years ago

Ok, I thought this was a crazy idea, but signing out makes it work correctly. Signing in to my account again breaks it. I'm not using any token at the moment, so rate limits shouldn't be it (?).

posted by dwelle almost 5 years ago

@fregante That isn't my avatar it belongs to the user https://github.com/1 and the avatar changes same as the number of the reactions as you see in the snip there are 2 rocket reaction so the avatar is for user https://github.com/2 same as for the thumps up https://github.com/7

I tried to only enable refined-github in incognito and the bug occurred there

posted by Almo7aya almost 5 years ago

I'm not receiving any avatar now :cry:

image

Or at least it's intermittent... Might have to do with GitHub API requests going down.

posted by jef almost 5 years ago

Refer to https://github.com/sindresorhus/refined-github/issues/3122

The feature is essentially broken by GitHub now and needs to be changed.

posted by fregante almost 5 years ago

Fund this Issue

$0.00
Funded

Pull requests