sindresorhus/refined-github

Project tabs don't fit on their line #3102

yallie posted onGitHub

<!-- Thanks for reporting a bug! â›° 1. Make sure the bug is caused by Refined GitHub. Try disabling the extension first. 2. Include a full URL where the bug appears. 3. Include a screenshot/gif Issues without a URL/screenshot will be closed image image image -->

Page url: https://github.com/sindresorhus/refined-github

Screenshot with refined-github enabled: image

Screenshot with refined-github disabled: image


That's ZenHub extension flexing out the .repo-nav element, causing elements we add there to flow down.

image

This is more of a compatibility issue between ZenHub and this extension than a bug from this issue.


Also @fregante WDYT about adding "more dropdown" and "releases tab" inside the ul as opposed to beside it?

posted by notlmn almost 5 years ago

That's ZenHub extension flexing out the .repo-nav element, causing elements we add there to flow down.

Oh, I thought I've disabled all github-related extensions before posting this issue.
I forgot about ZenHub, indeed. Thank you!

posted by yallie almost 5 years ago

Also @fregante WDYT about adding "more dropdown" and "releases tab" inside the ul as opposed to beside it?

Sounds good, GitHub must have changed the DOM.

Also I suggest reporting this to ZenHub. Why are they setting flex on the whole element? Doesn't look necessary.

posted by fregante almost 5 years ago

That's ZenHub extension flexing out the .repo-nav element, causing elements we add there to flow down.

Oh, I thought I've disabled all github-related extensions before posting this issue. I forgot about ZenHub, indeed. Thank you!

That did help us find this issue where the elements we add now appear after the settings tab. Sending in a fix for this.

image

posted by notlmn almost 5 years ago

This also explains why I’ve been seeing the Releases being added AFTER the settings tab. That’s not right

posted by fregante almost 5 years ago

Fund this Issue

$0.00
Funded

Pull requests