The issue has been closed

The commit title input length is now 20px wide #3080

webknjaz posted onGitHub

Refined GitHub enabled: <img width="374" alt="commit-message-incorrect" src="https://user-images.githubusercontent.com/578543/81558475-0531a480-938e-11ea-8c24-af11e7fe20a6.png">

Refined GitHub disabled: <img width="372" alt="commit-message-correct" src="https://user-images.githubusercontent.com/578543/81558503-17134780-938e-11ea-8fb2-054fe9eaf9b3.png">

This happens when merging PRs https://github.com/aio-libs/aiohttp/pull/4731 and editing individual files https://github.com/scop/aiohttp/edit/changelog-project-url/setup.py?pr=%2Faio-libs%2Faiohttp%2Fpull%2F4731.

Looks like it's because of

.rgh-monospace-textareas #merge_title_field, .rgh-monospace-textareas #commit-summary-input {
    width: calc(72ch + 18px);
    max-width: 100%;
}

I’m not seeing this when editing single files nor when merging PRs.

Do you have any other extensions running on the page? What browser?

posted by fregante almost 5 years ago

Google Chrome, 81.0.4044.122 (Official Build) (64-bit). Yeah. There are other extensions but I don't think they influence GitHub.

posted by webknjaz almost 5 years ago

Just checked that it's reproducible in incognito mode with this just extension enabled.

posted by webknjaz almost 5 years ago

Also, it was on Gentoo. When I tested on macOS (Chrome v80) it was fine. I must say that I may have my fontconfig slightly misconfigured and it may be selecting the wrong font to calculate 72ch.

posted by webknjaz almost 5 years ago

Can you try removing the max-width: 100% in the developer tools?

Alternatively also try changing the unit from ch to em

posted by fregante almost 5 years ago

These changes show up as injected stylesheet and are read-only in DevTools. But when I add width: 100% to the <input> element, it fixes the problem.

posted by webknjaz almost 5 years ago

That’s a difference change than what I suggested 😃 . If you can’t edit them, try:

max-width: none

width: calc(72em + 18px)

posted by fregante almost 5 years ago

max-width: none doesn't change anything. width: calc(72em + 18px) fixes it.

Can it be that ch counts the char width as 0 if an incorrect font is chosen?

posted by webknjaz almost 5 years ago

Can it be that ch counts the char width as 0 if an incorrect font is chosen?

Likely. Perhaps also try replacing the font-family to just monospace

Anyway this sounds like a system or browser problem not working correctly rather than Refined GitHub's.

We can't use the em unit either because it seems substantially different (72ch ≅ 43em on my system)

posted by fregante almost 5 years ago

Fund this Issue

$0.00

Funded

Pull requests

The commit title input length is now 20px wide #3080

Company

Community

Support

Connect