The issue has been closed
I think that GitHub changed markup for diff UI containing diff markers. Right now markers are being hidden using visibility: hidden (link), but we may need to use display: none.
This fails when the first character of the line is a tab, in which case it gets collapsed. This can be clearly seen code starting with spaces (demo).
And yes, using display: none on the pseudo elements did fix this for me, for code indented with tabs and spaces.
Test
Screenshot
posted by fregante almost 5 years ago I'm pretty sure what you're seeing is due to tab-size: 4, not those 2 features. Is this the "interference" you're seeing?
The first tab does seem to be collapsed to 2 spaces instead of 4.
The gif shows me toggling tab-size: 4 without running Refined GitHub
I'm pretty sure what you're seeing is due to tab-size: 4, not those 2 features. Is this the "interference" you're seeing?
I think that might be it, but not sure why that is happening.
I changed that recently (35303dc) because it caused #2970.
Edit: I tested this and display: none still causes #2970 so the suggested change can't be applied.
Tabs on https://github.com/sindresorhus/refined-github/pull/2925/files#diff-cc4aac3e9be04e0413c9520f223b493c, sample for #2970 is now being translated to 3 spaces instead of 4 in markdown files.
So is that the issue you’re talking about?
If so, this is unrelated to RGH.
Default tabs are 8 characters long but… the first tab is shown as 6 characters. That’s GitHub’s fault.
Refined GitHub only makes this more noticeable (because 4 chars become 2; by default 8 chars become 6, which isn’t as noticeable)
This is likely happening because the line (as far as the browser is concerned) includes the diff signs and the space after it. That’s 2 extra characters that shouldn’t be there.
I don’t know if there’s an easy way to convince the browser to start after the diff signs. My guess is that a block element resets the tabulations.
Maybe we can fix their bug, maybe not. Either way I suggest reporting it to GitHub:
The first tab is shown as 6 characters instead of 8
Perhaps it’s better to open a new, clearer issue for a feature request. Can you open it?
IssueHunt