sindresorhus/refined-github

Allow blacklisting certains urls or not running on large pages #3029

vjpr posted onGitHub

On some large pages, mostly PR changed files, there is sometimes a considerable slow down.

It would be good to have an option to prevent any changes running on certain pages, or to detect large PRs and disable things.


We're unlikely to add a setting for this, but we definitely improve the default performance.

Do you have any public PR you could link us to where you experience large slow downs when Refined GitHub is enabled, where it's faster when Refined GitHub is disabled?

posted by sindresorhus almost 5 years ago

@sindresorhus Just logged this one -> https://github.com/sindresorhus/refined-github/issues/3028

Although...after I disabled it, it improved things a bit but there are still 1s lags sometimes coming from github-bootstrap.js, so not sure how much blame can be made for this extension.

posted by vjpr almost 5 years ago

Do you have any public PR

Sorry! Misread your previous comment. Maybe I can put a PR together in a sample repo for testing.

posted by vjpr almost 5 years ago

sometimes coming from github-bootstrap.js

That's not Refined GitHub

posted by fregante almost 5 years ago

@fregante

coming from github-bootstrap.js, so not sure how much blame can be made for this extension.

Yep I know - which made me think perhaps my #3028 issue is not to do with the extension...

posted by vjpr almost 5 years ago

Disabling everything on a page isn't possible. We can't prevent CSS from being injected.

Disabling everything on a page probably isn't desirable, I'm sure that there are a few features you'll instantly miss.

I think it's best to improve the specific features that slow down, like I did in https://github.com/sindresorhus/refined-github/pull/2737 and like your specific issue in #3028

posted by fregante almost 5 years ago

It would be interesting however to proactively track possible slow features: https://github.com/sindresorhus/refined-github/issues/3032

posted by fregante almost 5 years ago
posted by fregante over 4 years ago

Fund this Issue

$0.00
Funded

Pull requests