"Send now" button may lose the review (`submit-review-as-single-comment`) #2978

fregante posted onGitHub

I can't replicate it anymore but it happened twice for me.

Maybe one of these 2 awaits are not happening:

Losing a comment is pretty bad.

I'd suggest adding:

a 10s timeout on the observeOneMutation (via https://github.com/sindresorhus/p-timeout)
window.onbeforeload to avoid users leaving the page (and also a 'pjax:start' listener)

posted by fregante almost 5 years ago

I found an error. getNewCommentField does not return a textarea as expected, in fact I have to select the textarea again later:

getNewCommentField should probably be replaced with elementReady or a plain select

posted by fregante almost 5 years ago

Fund this Issue

$0.00

Funded

Only logged in users can fund an issue

Pull requests