sindresorhus/refined-github

Drop clipping the commit title when merging in `sync-pr-commit-title` feature #2944

sindresorhus posted onGitHub


Iā€™d leave the logic around to enable the red highlight, but without using setValidity()

posted by fregante about 5 years ago

Clipping could be appropriate if limit-commit-title-length is enabled, but otherwise yes please.

posted by anorth about 5 years ago

It took me a while trying to figure out which RGH option was doing this.

I used to use limit-commit-title-length, but with semantic commits it's so easy to hit the 72char limit, and I was doing weird abbreviations all over the place to make it fit, which munged the automatic changelogs.

I've since turned that feature off, so having this feature clip the titles is kinda frustrating.

I find that more often than not this clipping feature causes me to spend more time when merging, because it'll clip a long title if there are multiple commits (which is generally the case in typescript-eslint).

posted by bradzacher almost 5 years ago

Fund this Issue

$0.00
Funded

Pull requests