`forked-to` only works on some repositories #2909

1. Visit https://github.com/jack1142/Red-DiscordBot
2. Wait 1 second
3. Visit https://github.com/Cog-Creators/Red-DiscordBot

Still no? #2892 was meant to fix this...

a. Are you using version 20.3.16? b. Same problem in both Chrome and Firefox? (Make sure the token is set in both)

@fregante I'm using 20.3.16 (in both) and same problem in both Chrome and Firefox (with token set it both)

One interesting thing I noticed when I opened jack1142/Red-DiscordBot is that it shows the link to fork (so the link to jack1142/Red-DiscordBot) there:

What's even more interesting, the link on jack1142/Red-DiscordBot shows only when I open the fork in Chrome 🤔

Can you look into this? The button is not supposed to show on your fork:

https://github.com/sindresorhus/refined-github/blob/eca9e80d26e7e9bc07d27b862c00f795c91f9ed1/source/features/forked-to.tsx#L31-L34

My guess is that you still have an old cache. Perhaps try clearing it in the options (very bottom of the page)

Clearing cache fixed it showing on fork.

The link to fork still doesn't show on source repo.

Any errors in Chrome's console?

None that I can see. I looked both in console of background page: and of the actual github page.

I'll try to pinpoint the issue tomorrow and give an update then.

I did a little debugging at it appears that isForkedRepo() call here returns false:

https://github.com/sindresorhus/refined-github/blob/6c46766237ccbf8a8c23ba07aca1e48a11a71b4b/source/features/forked-to.tsx#L90

I checked what that function does and by the looks of it, it checks if the repo is a fork and the page where the link should show is definitely not a fork (which I also verified by checking that meta attr - it's set to false):

https://github.com/sindresorhus/refined-github/blob/6c46766237ccbf8a8c23ba07aca1e48a11a71b4b/source/libs/page-detect.ts#L355

So the problem appears to be that the function checks if the repo is a fork rather than if the repo has forks.

So if I get this correctly, clearing cache might actually help you reproduce it.

Right, isForkedRepo means "is current repo a fork", not "current repo HAS forks", so the function does what it means to do.

The feature never really checks whether the current repo was forked because this feature is useful in the few situations where YOU forked a repo and are regularly contributing to it from the fork. Most repos you see are not in this situation, and we don't want to make HTTP calls unless they're useful most of the time. It's explained there:

https://github.com/sindresorhus/refined-github/blob/6c46766237ccbf8a8c23ba07aca1e48a11a71b4b/source/features/forked-to.tsx#L88-L89

This is why I suggested doing this:

1. Visit jack1142/Red-DiscordBot (the fork)

2. Wait 1 second (the fork is remembered in the cache)

3. Visit Cog-Creators/Red-DiscordBot (the source)

It first needs to see the fork, and then it adds the button on the source repo.

If after following those instructions you don't see the link to the fork added to the source repo, it may be because:

• the fork isn't being remembered
• the fork isn't being associated to the right source (<- most likely)
• the DOM has changed (it should throw an error)

Try this in the background page:

await browser.storage.local.get()

And look for something like cache:forked-to:cog-creators/red-discordbot

It can help you understand why it's not being associated correctly.

@fregante Ah, that makes sense. I checked the local storage and cache works (not a lot of entries since I cleared the cache 2 days ago/yesterday):

cache:forked-to:jack1142@Cog-Creators/Red-DiscordBot:
data: ["jack1142/red-discordbot"]
maxAge: 1585402612639
__proto__: Object

cache:forked-to:jack1142@jelmer/python-fastimport:
data: ["jack1142/python-fastimport"]
maxAge: 1585336802470
__proto__: Object

cache:forked-to:jack1142@sindresorhus/refined-github:
data: ["jack1142/refined-github"]
maxAge: 1585402706428
__proto__: Object

So looks like the problem here is that the repo key should be lowercase (I manually added lowercase cache entry and now the fork link works)